Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix un exist branch page loop request error #1090

Merged

Conversation

laojun
Copy link
Contributor

@laojun laojun commented Sep 6, 2021

What this PR does / why we need it:

fix: fix un exist branch page request error

Does this PR introduce a user interface change?

❎ No

ChangeLog

Language Changelog
🇺🇸 English fix: fix un exist branch page loop request error
🇨🇳 中文 fix: 修复无效分支的页面循环报错

Does this PR need be patched to older version?

❎ No

Which issue(s) this PR fixes:

Fixes #
https://erda-org.erda.cloud/erda/dop/projects/387/issues/all?id=219295&issueFilter__urlQuery=eyJpdGVyYXRpb25JRHMiOls1MDZdLCJzdGF0ZUJlbG9uZ3MiOlsiT1BFTiIsIldPUktJTkciLCJXT05URklYIiwiUkVPUEVOIiwiUkVTT0xWRUQiXSwiYXNzaWduZWVJRHMiOlsiMTAzOTAiXX0%3D&issueTable__urlQuery=eyJwYWdlTm8iOjEsICJwYWdlU2l6ZSI6MTB9&issueViewGroup__urlQuery=eyJ2YWx1ZSI6ImthbmJhbiIsImNoaWxkcmVuVmFsdWUiOnsia2FuYmFuIjoiZGVhZGxpbmUifX0%3D&iterationID=506&type=BUG

@laojun laojun added dop DevOps platform bugfix Used in pr labels Sep 6, 2021
@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

Merging #1090 (bee7dd2) into master (9c7eaee) will decrease coverage by 0.04%.
The diff coverage is 58.33%.

❗ Current head bee7dd2 differs from pull request most recent head c38ba18. Consider uploading reports for the commit c38ba18 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1090      +/-   ##
==========================================
- Coverage   82.81%   82.76%   -0.05%     
==========================================
  Files         115      115              
  Lines        7106     7115       +9     
  Branches     1967     1968       +1     
==========================================
+ Hits         5885     5889       +4     
- Misses       1184     1189       +5     
  Partials       37       37              
Impacted Files Coverage Δ
shell/app/common/components/load-more.tsx 89.39% <58.33%> (-7.10%) ⬇️

@daskyrk
Copy link
Contributor

daskyrk commented Sep 7, 2021

/approve

@erda-bot erda-bot added the approved Auto tagged by robot label Sep 7, 2021
@erda-bot erda-bot merged commit e5345ce into erda-project:master Sep 7, 2021
@laojun laojun deleted the hotfix/zxj-fix-unexist-branch-error branch September 22, 2021 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Auto tagged by robot bugfix Used in pr dop DevOps platform
Development

Successfully merging this pull request may close these issues.

3 participants