fix: Fixed the problem of directory hiding in test case page and test plan page #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
McDaddy
reviewed
May 14, 2021
| }, [treeData, query.caseId]); | ||
|
|
||
| useEffect(() => { | ||
| if (activeOuter) { | ||
| onAddNode(rootKey); | ||
| clearActiveOuter(); | ||
| } | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps |
There was a problem hiding this comment.
can u remove these lint disable line?
McDaddy
reviewed
May 14, 2021
| @@ -102,21 +102,20 @@ const TestSet = ({ | |||
| const projectInfo = projectStore.useStore(s => s.info); | |||
| const { getCases } = testCaseStore.effects; | |||
| const { triggerChoosenAll: resetChoosenAll } = testCaseStore.reducers; | |||
| const isAddNodeFromOuterRef = React.useRef(false); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Fixed the problem of directory hiding in test case page and test plan page
Which issue(s) this PR fixes:
Fixes #
Fixed the problem of directory hiding in test case page and test plan page
Does this PR introduce a user interface change?
Special notes for your reviewer:
This bug was caused by fixing of [fix: show test set after first adding it #136] last time.
now add a param which name is isAddNodeFromOuterRef to prevent unnecessary setting treeData when add caseSet