Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display groups in notification object(msp & cmp) #2023

Conversation

sherotree
Copy link
Contributor

What this PR does / why we need it:

display groups in notification object(msp & cmp)

Does this PR introduce a user interface change?

✅ Yes(screenshot is required)

before:
image

current:
image

ChangeLog

Language Changelog
🇺🇸 English In MSP and CMP, change the display content of the notification object of the notification strategy to display all notification groups instead of person
🇨🇳 中文 在微服务平台和多云管理平台中,将通知策略的通知对象显示内容改为显示所有通知组别而不是个人

Does this PR need be patched to older version?

✅ Yes(version is required)
release/1.4.1

Which issue(s) this PR fixes:

Fixes #
【告警】告警策略列表,当添加多个通知组时,列表中通知对象字段只显示了第一个

@sherotree sherotree added the bugfix Used in pr label Nov 17, 2021
@sherotree sherotree force-pushed the fix/display-groups-in-notification-object branch from 2f2cb78 to 93c4ec9 Compare November 17, 2021 06:26
@McDaddy McDaddy merged commit 8f4c5b9 into erda-project:master Nov 17, 2021
@McDaddy
Copy link
Contributor

McDaddy commented Nov 17, 2021

/cherry-pick release/1.4.1

erda-bot pushed a commit to erda-bot/erda-ui that referenced this pull request Nov 17, 2021
)

* fix: display groups in notification object in msp and cmp

* refactor: refactor code
McDaddy pushed a commit that referenced this pull request Nov 17, 2021
* fix: display groups in notification object in msp and cmp

* refactor: refactor code

Co-authored-by: sherotree <wytreeshero@163.com>
McDaddy pushed a commit that referenced this pull request Nov 17, 2021
* fix: remove VMS channel and SMS & VMS switch (#2024)

* fix: display groups in notification object(msp & cmp) (#2023) (#2026)

* fix: display groups in notification object in msp and cmp

* refactor: refactor code

Co-authored-by: sherotree <wytreeshero@163.com>

Co-authored-by: sherotree <wytreeshero@163.com>
Co-authored-by: erda-bot <81558540+erda-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Used in pr
Development

Successfully merging this pull request may close these issues.

2 participants