Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix gantt date error #2199

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

laojun
Copy link
Contributor

@laojun laojun commented Dec 3, 2021

What this PR does / why we need it:

fix: fix gantt date error

I have checked the following points:

  • I18n is finished and updated by cli
  • Form fields validation is added and length is limited
  • Display normally on small screen
  • Display normally when some data is empty or null
  • Display normally in english mode

Does this PR introduce a user interface change?

❎ No

ChangeLog

Language Changelog
🇺🇸 English fix: fix gantt date error, page crush
🇨🇳 中文 fix: 修复甘特图日期计算错误导致页面崩溃

Does this PR need be patched to older version?

❎ No

Which issue(s) this PR fixes:

Fixes #
https://erda-org.erda.cloud/erda/dop/projects/387/issues/all?id=260709&issueFilter__urlQuery=eyJzdGF0ZXMiOls0NDAyLDcxMDQsNzEwNSw0NDAzLDQ0MDQsNzEwNiw0NDA2LDQ0MDcsNDQxMiw0NTM4LDQ0MTMsNDQxNCw0NDE1LDQ0MTZdLCJhc3NpZ25lZUlEcyI6WyIxMDM5MCJdfQ%3D%3D&issueTable__urlQuery=eyJwYWdlTm8iOjEsICJwYWdlU2l6ZSI6MTB9&issueViewGroup__urlQuery=eyJ2YWx1ZSI6ImthbmJhbiIsImNoaWxkcmVuVmFsdWUiOnsia2FuYmFuIjoiZGVhZGxpbmUifX0%3D&iterationID=680&type=BUG

@laojun laojun added dop DevOps platform bugfix Used in pr labels Dec 3, 2021
@McDaddy McDaddy merged commit ef030a5 into erda-project:master Dec 3, 2021
@laojun laojun deleted the hotfix/fix-gantt-data-error branch December 6, 2021 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Used in pr dop DevOps platform
Development

Successfully merging this pull request may close these issues.

2 participants