Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate serviceIds before request #2245

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

Zero-Rock
Copy link
Contributor

What this PR does / why we need it:

I have checked the following points:

  • I18n is finished and updated by cli
  • Form fields validation is added and length is limited
  • Display normally on small screen
  • Display normally when some data is empty or null
  • Display normally in english mode

Does this PR introduce a user interface change?

✅ Yes(screenshot is required)
❎ No

ChangeLog

Language Changelog
🇺🇸 English
🇨🇳 中文

Does this PR need be patched to older version?

✅ Yes(version is required)
❎ No

Which issue(s) this PR fixes:

Fixes #

@Zero-Rock Zero-Rock added bugfix Used in pr msp Microservice platform labels Dec 9, 2021
@daskyrk
Copy link
Contributor

daskyrk commented Dec 9, 2021

/approve

@erda-bot erda-bot added the approved Auto tagged by robot label Dec 9, 2021
@erda-bot erda-bot merged commit ca8aa3b into erda-project:master Dec 9, 2021
@Zero-Rock Zero-Rock deleted the hotfix/msp-services branch December 10, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Auto tagged by robot bugfix Used in pr msp Microservice platform
Development

Successfully merging this pull request may close these issues.

3 participants