Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): configurable filter display bug after filter #2320

Conversation

hujiahao-hjh
Copy link
Contributor

What this PR does / why we need it:

Fix configurable filter display bug after filter:
Whether or not to update display bug after filter.

I have checked the following points:

  • I18n is finished and updated by cli
  • Form fields validation is added and length is limited
  • Display normally on small screen
  • Display normally when some data is empty or null
  • Display normally in english mode

Does this PR introduce a user interface change?

❎ No

ChangeLog

Language Changelog
🇺🇸 English
🇨🇳 中文

Does this PR need be patched to older version?

❎ No

Which issue(s) this PR fixes:

Fixes #

@hujiahao-hjh hujiahao-hjh added the bugfix Used in pr label Dec 19, 2021
@laojun
Copy link
Contributor

laojun commented Dec 19, 2021

/approve

@erda-bot erda-bot added the approved Auto tagged by robot label Dec 19, 2021
@erda-bot erda-bot merged commit 49f418e into erda-project:master Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Auto tagged by robot bugfix Used in pr
Development

Successfully merging this pull request may close these issues.

3 participants