Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed msp online bugs #2336

Merged
merged 2 commits into from
Dec 20, 2021
Merged

fixed msp online bugs #2336

merged 2 commits into from
Dec 20, 2021

Conversation

Zero-Rock
Copy link
Contributor

What this PR does / why we need it:

  • fix bug that topology nodes are out of view
  • fix service overview style

I have checked the following points:

  • I18n is finished and updated by cli
  • Form fields validation is added and length is limited
  • Display normally on small screen
  • Display normally when some data is empty or null
  • Display normally in english mode

Does this PR introduce a user interface change?

❎ No

ChangeLog

Language Changelog
🇺🇸 English
🇨🇳 中文

Does this PR need be patched to older version?

❎ No

Which issue(s) this PR fixes:

Fixes #

@daskyrk
Copy link
Contributor

daskyrk commented Dec 20, 2021

/approve

@erda-bot erda-bot added the approved Auto tagged by robot label Dec 20, 2021
@erda-bot erda-bot merged commit 775b480 into erda-project:master Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daskyrk daskyrk daskyrk left review comments

@erda-bot erda-bot erda-bot approved these changes

Assignees
No one assigned
Labels
approved Auto tagged by robot
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zero-Rock @daskyrk @erda-bot