Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/select onchange #2358

Merged
merged 2 commits into from
Dec 22, 2021
Merged

Conversation

daskyrk
Copy link
Contributor

@daskyrk daskyrk commented Dec 22, 2021

What this PR does / why we need it:

fix: select not trigger passed in onChange function

I have checked the following points:

  • I18n is finished and updated by cli
  • Form fields validation is added and length is limited
  • Display normally on small screen
  • Display normally when some data is empty or null
  • Display normally in english mode

Does this PR introduce a user interface change?

❎ No

ChangeLog

Language Changelog
🇺🇸 English fix select not trigger switch other fields
🇨🇳 中文 修复下拉选项无法触发其他字段变化的问题

Does this PR need be patched to older version?

yes
hotfix/12-21

Which issue(s) this PR fixes:

Fixes #

@daskyrk daskyrk added the bugfix Used in pr label Dec 22, 2021
@Zero-Rock
Copy link
Contributor

/approve

@erda-bot erda-bot added the approved Auto tagged by robot label Dec 22, 2021
@erda-bot erda-bot merged commit 7588a7c into erda-project:master Dec 22, 2021
@daskyrk
Copy link
Contributor Author

daskyrk commented Dec 22, 2021

/cherry-pick hotfix/12-21

erda-bot pushed a commit to erda-bot/erda-ui that referenced this pull request Dec 22, 2021
* fix: select not trigger passed in onChange function

* fix: update tag style in filter
daskyrk added a commit that referenced this pull request Dec 22, 2021
* fix: select not trigger passed in onChange function

* fix: update tag style in filter

Co-authored-by: 随风 <daskyrk@users.noreply.github.com>
daskyrk added a commit that referenced this pull request Dec 23, 2021
* fix: hide email and label of member table (#2343) (#2346)

Co-authored-by: sherotree <wytreeshero@163.com>

* feat: modify route about service analysis (#2342) (#2347)

* feat: modiify route about service analysis

* fix: route when click service monitoor menu

Co-authored-by: sherotree <wytreeshero@163.com>

* fix: trace detail bgo back to transaction in service monitor (#2349) (#2350)

Co-authored-by: sherotree <wytreeshero@163.com>

* fix(common): msp project detail display bug in orgCenter (#2351) (#2352)

Co-authored-by: hujiahao-hjh <82502479+hujiahao-hjh@users.noreply.github.com>

* Hotfix/select onchange (#2358) (#2359)

* fix: select not trigger passed in onChange function

* fix: update tag style in filter

Co-authored-by: 随风 <daskyrk@users.noreply.github.com>

Co-authored-by: erda-bot <81558540+erda-bot@users.noreply.github.com>
Co-authored-by: sherotree <wytreeshero@163.com>
Co-authored-by: hujiahao-hjh <82502479+hujiahao-hjh@users.noreply.github.com>
@daskyrk daskyrk deleted the hotfix/select-onchange branch January 5, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Auto tagged by robot bugfix Used in pr
Development

Successfully merging this pull request may close these issues.

3 participants