Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add land page #2567

Merged
merged 9 commits into from
Jan 11, 2022
Merged

feat: add land page #2567

merged 9 commits into from
Jan 11, 2022

Conversation

daskyrk
Copy link
Contributor

@daskyrk daskyrk commented Jan 10, 2022

What this PR does / why we need it:

add land page

I have checked the following points:

  • I18n is finished and updated by cli
  • Form fields validation is added and length is limited
  • Display normally on small screen
  • Display normally when some data is empty or null
  • Display normally in english mode

Does this PR introduce a user interface change?

✅ Yes(screenshot is required)
image

ChangeLog

Language Changelog
🇺🇸 English add land page
🇨🇳 中文 新增着陆页

Does this PR need be patched to older version?

❎ No

Which issue(s) this PR fixes:

Fixes #

@daskyrk daskyrk added the feature new feature label Jan 10, 2022
@McDaddy
Copy link
Contributor

McDaddy commented Jan 11, 2022

/approve

@erda-bot erda-bot added the approved Auto tagged by robot label Jan 11, 2022
@erda-bot erda-bot merged commit 64cf04f into erda-project:master Jan 11, 2022
@daskyrk daskyrk deleted the feature/land-page branch February 9, 2022 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Auto tagged by robot feature new feature
Development

Successfully merging this pull request may close these issues.

3 participants