Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Do not drill down at the application level and change the menu to tabs #2941

Merged
merged 17 commits into from
Feb 17, 2022

Conversation

daskyrk
Copy link
Contributor

@daskyrk daskyrk commented Feb 17, 2022

What this PR does / why we need it:

feat: Do not drill down at the application level and change the menu to tabs

I have checked the following points:

  • I18n is finished and updated by cli
  • Form fields validation is added and length is limited
  • Display normally on small screen
  • Display normally when some data is empty or null
  • Display normally in english mode

Does this PR introduce a user interface change?

✅ Yes(screenshot is required)
image
->
image

ChangeLog

Language Changelog
🇺🇸 English Do not drill down at the application level and change the menu to tabs
🇨🇳 中文 应用级别不进行下钻,菜单改为 tabs

Does this PR need be patched to older version?

❎ No

Which issue(s) this PR fixes:

Fixes #

@daskyrk daskyrk added dop DevOps platform refactor Refactor labels Feb 17, 2022
@erda-bot erda-bot added the feature new feature label Feb 17, 2022
@daskyrk daskyrk marked this pull request as draft February 17, 2022 03:37
@daskyrk daskyrk marked this pull request as ready for review February 17, 2022 13:35
@laojun
Copy link
Contributor

laojun commented Feb 17, 2022

/approve

@erda-bot erda-bot added the approved Auto tagged by robot label Feb 17, 2022
@erda-bot erda-bot merged commit bee4bbf into erda-project:master Feb 17, 2022
@daskyrk daskyrk deleted the faeture/app-flatten branch March 17, 2022 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Auto tagged by robot dop DevOps platform feature new feature refactor Refactor
Development

Successfully merging this pull request may close these issues.

3 participants