Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update application jump link to project level page #2963

Merged
merged 8 commits into from
Feb 18, 2022
Merged

fix: update application jump link to project level page #2963

merged 8 commits into from
Feb 18, 2022

Conversation

daskyrk
Copy link
Contributor

@daskyrk daskyrk commented Feb 18, 2022

What this PR does / why we need it:

fix: update application jump link to project level page

I have checked the following points:

  • I18n is finished and updated by cli
  • Form fields validation is added and length is limited
  • Display normally on small screen
  • Display normally when some data is empty or null
  • Display normally in english mode

Does this PR introduce a user interface change?

❎ No

ChangeLog

Language Changelog
🇺🇸 English fix: update application jump link to project level page
🇨🇳 中文 更新应用级页面的链接到项目级

Does this PR need be patched to older version?

❎ No

Which issue(s) this PR fixes:

Fixes #

@daskyrk daskyrk added dop DevOps platform bugfix Used in pr labels Feb 18, 2022
@McDaddy McDaddy merged commit da9d3e6 into erda-project:master Feb 18, 2022
@daskyrk daskyrk deleted the hotfix/jump-link branch March 17, 2022 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McDaddy McDaddy McDaddy approved these changes

Assignees
No one assigned
Labels
bugfix Used in pr dop DevOps platform
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daskyrk @McDaddy