Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable branch and mr tabs when repo is empty #2975

Merged
merged 3 commits into from
Feb 19, 2022

Conversation

daskyrk
Copy link
Contributor

@daskyrk daskyrk commented Feb 19, 2022

What this PR does / why we need it:

empty repo should disable commits\branches\mr tab

I have checked the following points:

  • I18n is finished and updated by cli
  • Form fields validation is added and length is limited
  • Display normally on small screen
  • Display normally when some data is empty or null
  • Display normally in english mode

Does this PR introduce a user interface change?

✅ Yes(screenshot is required)
image

ChangeLog

Language Changelog
🇺🇸 English fix: disable branch and mr tabs when repo is empty
🇨🇳 中文 代码为空的应用禁用提交、分支和合并请求的 tab

Does this PR need be patched to older version?

❎ No

Which issue(s) this PR fixes:

Fixes #

@daskyrk daskyrk added the bugfix Used in pr label Feb 19, 2022
@McDaddy McDaddy merged commit 9fdfb19 into erda-project:master Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Used in pr
Development

Successfully merging this pull request may close these issues.

2 participants