Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: microService to msp #407

Merged
merged 2 commits into from
Jun 28, 2021

Conversation

laojun
Copy link
Contributor

@laojun laojun commented Jun 25, 2021

What type of PR is this?

  • Feature
  • Bugfix
  • Test
  • Documentation
  • Refactor
  • Style
  • Chore

What this PR does / why we need it:

refactor: microService to msp

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user interface change?

  • Yes(screenshot is required)
  • No

Special notes for your reviewer:

@laojun laojun added msp Microservice platform refactor Refactor labels Jun 25, 2021
@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #407 (e6a3f55) into master (07129b5) will increase coverage by 9.72%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   59.42%   69.14%   +9.72%     
==========================================
  Files         113      115       +2     
  Lines        6445     6632     +187     
  Branches     1762     1680      -82     
==========================================
+ Hits         3830     4586     +756     
+ Misses       2596     2025     -571     
- Partials       19       21       +2     
Impacted Files Coverage Δ
shell/app/common/components/addon-resource.jsx 100.00% <ø> (ø)
...l/app/common/components/authorize-member-modal.tsx 34.09% <0.00%> (ø)
shell/app/common/components/contractive-filter.tsx 5.72% <0.00%> (ø)
shell/app/common/components/copy.tsx 77.50% <0.00%> (ø)
shell/app/common/components/image-upload.tsx 100.00% <ø> (+75.71%) ⬆️
shell/app/common/components/load-more-selector.tsx 8.45% <ø> (ø)
shell/app/common/components/member-selector.tsx 15.58% <0.00%> (ø)
shell/app/common/components/members-table.tsx 13.67% <0.00%> (-0.20%) ⬇️
shell/app/common/components/add-member-modal.tsx 24.13% <10.00%> (-4.44%) ⬇️
shell/app/common/utils/api-creator.ts 95.74% <95.74%> (ø)
... and 24 more

@daskyrk
Copy link
Contributor

daskyrk commented Jun 28, 2021

/approve

@erda-bot erda-bot added the approved Auto tagged by robot label Jun 28, 2021
@erda-bot erda-bot merged commit d79f4c4 into erda-project:master Jun 28, 2021
@laojun laojun deleted the feature/zxj-microService-to-msp branch July 6, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Auto tagged by robot msp Microservice platform refactor Refactor
Development

Successfully merging this pull request may close these issues.

3 participants