Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/add wrapped-table and fix table bug #736

Merged
merged 10 commits into from
Jul 23, 2021

Conversation

hujiahao-hjh
Copy link
Contributor

@hujiahao-hjh hujiahao-hjh commented Jul 22, 2021

What this PR does / why we need it:

add wrapped-table and fix table bug

Does this PR introduce a user interface change?

❎ No

ChangeLog

Language Changelog
🇺🇸 English fix some table bugs: Column width is too long or insufficient, the table exceeds the page, uniform overflow ellipsis
🇨🇳 中文 解决了一些表格的问题:列宽过长或不足,表格超出页面,统一溢出省略

Which versions should be patched?

Which issue(s) this PR fixes:

Fixes # some table bugs

@hujiahao-hjh hujiahao-hjh added refactor Refactor bugfix Used in pr labels Jul 22, 2021
@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #736 (5250c67) into master (66e7161) will decrease coverage by 0.01%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #736      +/-   ##
==========================================
- Coverage   81.15%   81.13%   -0.02%     
==========================================
  Files         113      113              
  Lines        6687     6691       +4     
  Branches     1834     1836       +2     
==========================================
+ Hits         5427     5429       +2     
- Misses       1228     1229       +1     
- Partials       32       33       +1     
Impacted Files Coverage Δ
...l/app/common/components/authorize-member-modal.tsx 95.55% <ø> (ø)
shell/app/common/components/key-value-table.tsx 96.15% <ø> (-0.03%) ⬇️
shell/app/common/components/members-table.tsx 90.90% <84.61%> (-0.72%) ⬇️

@daskyrk
Copy link
Contributor

daskyrk commented Jul 23, 2021

/approve

@erda-bot erda-bot added the approved Auto tagged by robot label Jul 23, 2021
@erda-bot erda-bot merged commit 8f634b6 into erda-project:master Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Auto tagged by robot bugfix Used in pr refactor Refactor
Development

Successfully merging this pull request may close these issues.

4 participants