-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify cluster_name and application_id in expression filters #1425
Merged
erda-bot
merged 11 commits into
erda-project:master
from
Counterflowwind:hotfix/pjy_kubernetes_recover
Aug 16, 2021
Merged
modify cluster_name and application_id in expression filters #1425
erda-bot
merged 11 commits into
erda-project:master
from
Counterflowwind:hotfix/pjy_kubernetes_recover
Aug 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1425 +/- ##
==========================================
+ Coverage 12.00% 12.05% +0.04%
==========================================
Files 990 990
Lines 103737 103749 +12
==========================================
+ Hits 12455 12502 +47
+ Misses 90172 90078 -94
- Partials 1110 1169 +59
|
liuhaoyang
previously approved these changes
Aug 13, 2021
/approve |
erda-bot
previously approved these changes
Aug 13, 2021
Counterflowwind
dismissed stale reviews from erda-bot and liuhaoyang
via
August 16, 2021 03:31
c7c8541
liuhaoyang
previously approved these changes
Aug 16, 2021
/approve |
erda-bot
approved these changes
Aug 16, 2021
/cherry-pick release/1.2 |
erda-bot
pushed a commit
to erda-bot/erda
that referenced
this pull request
Aug 16, 2021
…oject#1425) * change kubernetes组件实例Ready状态异常 recover is true * modify cluster_name and application_id value in expression filters * modify sql delete commit * delete annotation * add ToDBAlertExpressionModel test function * add filters in test * add filters in test * modify filters in template
liuhaoyang
pushed a commit
that referenced
this pull request
Aug 16, 2021
…1459) * change kubernetes组件实例Ready状态异常 recover is true * modify cluster_name and application_id value in expression filters * modify sql delete commit * delete annotation * add ToDBAlertExpressionModel test function * add filters in test * add filters in test * modify filters in template Co-authored-by: panjiayao <44628544+Counterflowwind@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Add one of the following kinds:
/kind bug
What this PR does / why we need it:
modify cluster_name and application_id in expression filters
Specified Reviewers:
/assign @liuhaoyang
ChangeLog