Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add event list scenario #1542

Merged
merged 3 commits into from
Aug 24, 2021

Conversation

CraigMChen
Copy link
Contributor

What type of this PR

Add one of the following kinds:

/kind feature

What this PR does / why we need it:

  1. modify bundle and apistruct for steve server
  2. add component protocol scenario events list for dashboard

Specified Reviewers:

/assign @johnlanni

ChangeLog

Language Changelog
🇺🇸 English
🇨🇳 中文

@erda-bot erda-bot requested a review from johnlanni August 24, 2021 08:06
@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #1542 (b0d64eb) into master (cfff46e) will increase coverage by 0.02%.
The diff coverage is 21.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1542      +/-   ##
==========================================
+ Coverage   12.30%   12.33%   +0.02%     
==========================================
  Files        1019     1021       +2     
  Lines      107200   107589     +389     
==========================================
+ Hits        13191    13270      +79     
- Misses      92596    92906     +310     
  Partials     1413     1413              
Impacted Files Coverage Δ
apistructs/component_protocol.go 0.00% <ø> (ø)
apistructs/steve.go 0.00% <0.00%> (ø)
modules/cmp/steve/aggregator.go 0.00% <ø> (ø)
...s/cmp-dashboard-events/components/filter/render.go 4.08% <4.08%> (ø)
...p-dashboard-events/components/eventTable/render.go 33.95% <33.95%> (ø)

@CraigMChen CraigMChen force-pushed the component-protocol-events branch from 943a374 to 83c6da3 Compare August 24, 2021 08:35
@johnlanni
Copy link
Contributor

/approve

@erda-bot erda-bot merged commit 51246d9 into erda-project:master Aug 24, 2021
@CraigMChen CraigMChen deleted the component-protocol-events branch August 30, 2021 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants