Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/pipeline support multi containers monitor #1777

Conversation

chengjoey
Copy link
Contributor

@chengjoey chengjoey commented Sep 10, 2021

What type of this PR

Add one of the following kinds:
/kind feature

What this PR does / why we need it:

support multi containers monitor

Which issue(s) this PR fixes:

  • Fixes #your-issue_number
  • [Erda Cloud Issue Link](paste your link here)
  • master pr

Specified Reviewers:

/assign @your-reviewer

ChangeLog

Language Changelog
🇺🇸 English support multi containers monitor
🇨🇳 中文 支持任务多容器监控

@chengjoey chengjoey force-pushed the hotfix/pipeline-support-multi-containers-monitor branch from c02c5bf to 36f4a09 Compare September 10, 2021 02:10
@sfwn
Copy link
Member

sfwn commented Sep 10, 2021

link master pr.

@sfwn
Copy link
Member

sfwn commented Sep 10, 2021

Test in erda 1.2.

@chengjoey chengjoey force-pushed the hotfix/pipeline-support-multi-containers-monitor branch from 82f5824 to cf808c3 Compare September 10, 2021 03:19
@chengjoey chengjoey force-pushed the hotfix/pipeline-support-multi-containers-monitor branch from 75b39ac to 02f3dba Compare September 10, 2021 03:45
@chengjoey
Copy link
Contributor Author

image
image
tested in erda test 1.2 env

@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #1777 (5756002) into release/1.2 (a0637cd) will increase coverage by 0.02%.
The diff coverage is 52.05%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/1.2    #1777      +/-   ##
===============================================
+ Coverage        12.40%   12.43%   +0.02%     
===============================================
  Files              992      993       +1     
  Lines           103421   103490      +69     
===============================================
+ Hits             12833    12871      +38     
- Misses           89443    89473      +30     
- Partials          1145     1146       +1     
Impacted Files Coverage Δ
apistructs/pipeline_task.go 77.19% <ø> (ø)
modules/dop/endpoints/cicd.go 0.00% <0.00%> (ø)
modules/pipeline/spec/pipeline_task.go 24.00% <0.00%> (-0.33%) ⬇️
modules/pipeline/pkg/containers/task_container.go 95.00% <95.00%> (ø)

@sfwn
Copy link
Member

sfwn commented Sep 10, 2021

/approve

@erda-bot erda-bot merged commit 9b5e7c4 into erda-project:release/1.2 Sep 10, 2021
@chengjoey chengjoey deleted the hotfix/pipeline-support-multi-containers-monitor branch November 15, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants