fix: gittar remove skipAuth #1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1856 +/- ##
==========================================
+ Coverage 14.79% 14.82% +0.03%
==========================================
Files 1128 1130 +2
Lines 113494 113925 +431
==========================================
+ Hits 16787 16893 +106
- Misses 94816 95125 +309
- Partials 1891 1907 +16
|
littlejiancc
force-pushed
the
feature/gittar-skip
branch
from
86f2362 to
6227b64
Compare
sfwn
requested changes
Sep 14, 2021
| @@ -453,3 +446,11 @@ func getOrgIDV3(c *webcontext.Context, orgName string) (int64, error) { | |||
| } | |||
| return orgID, nil | |||
| } | |||
|
|
|||
| // isGitProtocolRequest if request like git clone,git push... return true | |||
| func isGitProtocolRequest(c *webcontext.Context) bool { | |||
modules/gittar/auth/auth.go
Outdated
| return | ||
| } | ||
| logrus.Infof("repo: %s userId: %v, username: %s", repoName, userIdStr, userInfoDto.Username) | ||
| //校验通过缓存5分钟结果 |
littlejiancc
force-pushed
the
feature/gittar-skip
branch
3 times, most recently
from
29ac3bb to
bacccf7
Compare
littlejiancc
force-pushed
the
feature/gittar-skip
branch
from
bacccf7 to
ff40be8
Compare
sfwn
approved these changes
Sep 15, 2021
|
/approve |
erda-bot
approved these changes
Sep 15, 2021
|
/cherry-pick release/1.3 |
erda-bot
pushed a commit
to erda-bot/erda
that referenced
this pull request
Sep 15, 2021
* fix: remove skipAuth * polish the code and add unit test
erda-bot
added a commit
that referenced
this pull request
Sep 15, 2021
|
/cherry-pick release/1.3 |
|
Automated cherry pick failed, please resolve the confilcts and create PR manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
/kind feature
What this PR does / why we need it:
fix: gittar remove skipAuth
Which issue(s) this PR fixes:
【gittar】鉴权取消skipAuth
Specified Reviewers:
/assign @sfwn
ChangeLog
Need cherry-pick to release versions?
Add comment like
/cherry-pick release/1.0when this PR is merged.