Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: can not reference the table which is not created in the same moduel #2031

Merged
merged 1 commit into from
Sep 22, 2021
Merged

feature: can not reference the table which is not created in the same moduel #2031

merged 1 commit into from
Sep 22, 2021

Conversation

dspo
Copy link
Contributor

@dspo dspo commented Sep 22, 2021

What type of this PR

Add one of the following kinds:
/kind feature

What this PR does / why we need it:

feature: can not reference the table which is not created in the same moduel

Which issue(s) this PR fixes:

  • Fixes #your-issue_number
  • [Erda Cloud Issue Link](paste your link here)

Specified Reviewers:

/assign @your-reviewer

ChangeLog

Language Changelog
🇺🇸 English
🇨🇳 中文

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #2031 (a06e8d1) into master (6221cb3) will increase coverage by 0.03%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2031      +/-   ##
==========================================
+ Coverage   15.56%   15.60%   +0.03%     
==========================================
  Files        1143     1143              
  Lines      109676   109716      +40     
==========================================
+ Hits        17074    17120      +46     
+ Misses      90898    90882      -16     
- Partials     1704     1714      +10     
Impacted Files Coverage Δ
pkg/database/sqlparser/migrator/scripts.go 32.50% <92.85%> (+5.86%) ⬆️
...tocol/components/issue-manage/issueTable/render.go 38.56% <0.00%> (+4.10%) ⬆️

@johnlanni
Copy link
Contributor

/approve

@erda-bot erda-bot merged commit 24c6822 into erda-project:master Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants