feature: add costTime of autoTest plan list #2040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Automated cherry pick can ONLY be triggered when this PR is MERGED! |
Codecov Report
@@ Coverage Diff @@
## master #2040 +/- ##
=======================================
Coverage 15.53% 15.54%
=======================================
Files 1169 1169
Lines 114044 114073 +29
=======================================
+ Hits 17712 17727 +15
+ Misses 94341 94340 -1
- Partials 1991 2006 +15
|
sfwn
requested changes
Sep 23, 2021
| return "-" | ||
| } | ||
|
|
||
| rsp, err := a.CtxBdl.Bdl.GetPipeline(*task.SnippetPipelineID) |
There was a problem hiding this comment.
snippet task can also use task's costTimeSec.
There was a problem hiding this comment.
You have to care about performance issue.
There was a problem hiding this comment.
the costTimeSec of snippet task is always -1
There was a problem hiding this comment.
now update snippet pipeline task time when reconciler done
littlejiancc
force-pushed
the
feature/dop-autotest
branch
from
4a1fa0d to
2d0add9
Compare
sfwn
requested changes
Sep 24, 2021
| @@ -189,6 +189,27 @@ func (client *Client) UpdatePipelineTaskStatus(id uint64, status apistructs.Pipe | |||
| return err | |||
| } | |||
|
|
|||
| func (client *Client) UpdatePipelineTaskTime(p *spec.Pipeline, ops ...SessionOption) error { | |||
There was a problem hiding this comment.
Add comment for exported function.
|
Add screenshot of snippet task time related data. |
|
sfwn
approved these changes
Sep 24, 2021
sfwn
approved these changes
Sep 24, 2021
|
/approve |
erda-bot
approved these changes
Sep 24, 2021
|
/cherry-pick release/1.3 |
erda-bot
pushed a commit
to erda-bot/erda
that referenced
this pull request
Sep 24, 2021
* feature: add exec time of autoTest scene list * fix: update pipeline task when fulfillParentSnippetTask * fix: add comment
erda-bot
added a commit
that referenced
this pull request
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
/kind feature
What this PR does / why we need it:
feature: add costTime of autoTest plan list
Which issue(s) this PR fixes:
https://erda.cloud/erda/dop/projects/387/issues/all?id=222572&issueFilter__urlQuery=eyJzdGF0ZUJlbG9uZ3MiOlsiT1BFTiIsIldPUktJTkciLCJXT05URklYIiwiUkVPUEVOIiwiUkVTT0xWRUQiXSwiYXNzaWduZWVJRHMiOlsiMTAwMTI2MSJdfQ%3D%3D&issueTable__urlQuery=eyJwYWdlTm8iOjF9&issueViewGroup__urlQuery=eyJ2YWx1ZSI6ImthbmJhbiIsImNoaWxkcmVuVmFsdWUiOnsia2FuYmFuIjoiZGVhZGxpbmUifX0%3D&iterationID=506&type=TASK
Specified Reviewers:
/assign @sfwn
ChangeLog
Need cherry-pick to release versions?
/cherry-pick release/1.3
Add comment like
/cherry-pick release/1.0when this PR is merged.