Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autotest step input support point param #2046

Merged

Conversation

chengjoey
Copy link
Contributor

What type of this PR

Add one of the following kinds:
/kind bug

What this PR does / why we need it:

autotest step input support point param

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @your-reviewer

ChangeLog

Language Changelog
🇺🇸 English autotest step input support point param
🇨🇳 中文 支持自动化测试输入点

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@chengjoey
Copy link
Contributor Author

chengjoey commented Sep 23, 2021

image
image

@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #2046 (9d6b7b6) into master (c8c038e) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2046   +/-   ##
=======================================
  Coverage   15.17%   15.17%           
=======================================
  Files        1160     1160           
  Lines      113292   113308   +16     
=======================================
+ Hits        17190    17198    +8     
+ Misses      94420    94365   -55     
- Partials     1682     1745   +63     
Impacted Files Coverage Δ
...os/auto-test-scenes/components/apiEditor/helper.go 38.29% <ø> (ø)
modules/monitor/apm/topology/topology.go 17.10% <0.00%> (+0.08%) ⬆️
modules/msp/menu/menu.service.go 48.88% <0.00%> (+2.48%) ⬆️

@sfwn
Copy link
Member

sfwn commented Sep 23, 2021

Dot only allowed in query param key.

@chengjoey chengjoey force-pushed the fix/autotest-input-param-point branch from eb06797 to 01d2541 Compare September 23, 2021 05:38
@chengjoey chengjoey force-pushed the fix/autotest-input-param-point branch from 01d2541 to 9d6b7b6 Compare September 23, 2021 07:18
@sfwn
Copy link
Member

sfwn commented Sep 23, 2021

/approve

@erda-bot erda-bot merged commit 65fd3c9 into erda-project:master Sep 23, 2021
@chengjoey
Copy link
Contributor Author

/cherry-pick release/1.3

erda-bot pushed a commit to erda-bot/erda that referenced this pull request Sep 23, 2021
erda-bot added a commit that referenced this pull request Sep 23, 2021
Co-authored-by: chengjoey <30427474+chengjoey@users.noreply.github.com>
@chengjoey chengjoey deleted the fix/autotest-input-param-point branch November 15, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants