Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: db_type support #2049

Merged
merged 3 commits into from
Sep 23, 2021
Merged

Conversation

innerpeacez
Copy link
Contributor

What type of this PR

Add one of the following kinds:
/kind feature

Specified Reviewers:

/assign @liuhaoyang @recallsong

@innerpeacez innerpeacez added feature msp microsevice platform labels Sep 23, 2021
@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #2049 (cea1285) into master (36b4736) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2049   +/-   ##
=======================================
  Coverage   15.17%   15.17%           
=======================================
  Files        1160     1160           
  Lines      113292   113308   +16     
=======================================
+ Hits        17190    17198    +8     
+ Misses      94420    94365   -55     
- Partials     1682     1745   +63     
Impacted Files Coverage Δ
modules/monitor/apm/topology/topology.go 17.10% <50.00%> (+0.08%) ⬆️
modules/msp/menu/menu.service.go 48.88% <0.00%> (+2.48%) ⬆️

@liuhaoyang
Copy link
Contributor

/approve

@erda-bot erda-bot merged commit 01e3901 into erda-project:master Sep 23, 2021
@liuhaoyang
Copy link
Contributor

/cherry-pick release/1.3

erda-bot pushed a commit to erda-bot/erda that referenced this pull request Sep 23, 2021
* db_type support

* metric expression

* rm service_node from jvm_memory and nodejs_memory
erda-bot added a commit that referenced this pull request Sep 23, 2021
* db_type support

* metric expression

* rm service_node from jvm_memory and nodejs_memory

Co-authored-by: innerpeacez <innerpeace.zhai@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved feature msp microsevice platform
Development

Successfully merging this pull request may close these issues.

3 participants