Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix audit #2063

Merged
merged 1 commit into from
Sep 23, 2021
Merged

fix audit #2063

merged 1 commit into from
Sep 23, 2021

Conversation

CraigMChen
Copy link
Contributor

What type of this PR

Add one of the following kinds:

/kind bug

What this PR does / why we need it:

  1. add '\n' before kubecl-shell audit log
  2. do not create audit if length of cmd is 0

Specified Reviewers:

/assign @johnlanni

ChangeLog

Language Changelog
🇺🇸 English
🇨🇳 中文

@erda-bot erda-bot requested a review from johnlanni September 23, 2021 11:25
@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #2063 (9cdbb15) into master (f184f42) will increase coverage by 0.00%.
The diff coverage is 57.14%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2063   +/-   ##
=======================================
  Coverage   15.49%   15.50%           
=======================================
  Files        1161     1161           
  Lines      113464   113470    +6     
=======================================
+ Hits        17585    17590    +5     
- Misses      93911    93912    +1     
  Partials     1968     1968           
Impacted Files Coverage Δ
modules/cmp/steve/middleware/audit.go 33.72% <0.00%> (+1.82%) ⬆️
modules/cmp/steve/middleware/auth.go 46.07% <100.00%> (ø)

@CraigMChen CraigMChen added cmp cloud management platform manag bugfix labels Sep 23, 2021
@johnlanni
Copy link
Contributor

/approve

@erda-bot erda-bot merged commit fe4f001 into erda-project:master Sep 23, 2021
@johnlanni
Copy link
Contributor

/cherry-pick release/1.3

erda-bot pushed a commit to erda-bot/erda that referenced this pull request Sep 23, 2021
erda-bot added a commit that referenced this pull request Sep 23, 2021
Co-authored-by: CMC <49681321+CraigMChen@users.noreply.github.com>
@CraigMChen CraigMChen deleted the fix-audit branch October 12, 2021 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved bugfix cmp cloud management platform manag
Development

Successfully merging this pull request may close these issues.

3 participants