get execute env from report env #2064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
specify env: empty env: |
Codecov Report
@@ Coverage Diff @@
## master #2064 +/- ##
==========================================
+ Coverage 15.17% 15.49% +0.32%
==========================================
Files 1160 1161 +1
Lines 113308 113480 +172
==========================================
+ Hits 17198 17588 +390
+ Misses 94365 93913 -452
- Partials 1745 1979 +234
|
sfwn
requested changes
Sep 23, 2021
| if err != nil { | ||
| return "" | ||
| } | ||
| return fmt.Sprintf("%v", configData.Meta[autotest.CmsCfgKeyDisplayName]) |
There was a problem hiding this comment.
judge autotest.CmsCfgKeyDisplayName is existed in meta
add test if meta is nil
chengjoey
force-pushed
the
fix/autotest-execute-config-name
branch
from
cbff251 to
fbbae33
Compare
sfwn
approved these changes
Sep 24, 2021
|
/approve |
erda-bot
approved these changes
Sep 24, 2021
|
/cherry-pick release/1.3 |
erda-bot
pushed a commit
to erda-bot/erda
that referenced
this pull request
Sep 24, 2021
erda-bot
added a commit
that referenced
this pull request
Sep 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Add one of the following kinds:
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Specified Reviewers:
/assign @your-reviewer
ChangeLog
Need cherry-pick to release versions?
Add comment like
/cherry-pick release/1.0when this PR is merged.