feature: scene set supports parallel in autoTest #2173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Automated cherry pick can ONLY be triggered when this PR is MERGED! |
littlejiancc
force-pushed
the
feature/dop-sceneSet-arallel
branch
from
f24ea3d to
de98051
Compare
Codecov Report
@@ Coverage Diff @@
## master #2173 +/- ##
==========================================
- Coverage 15.96% 15.62% -0.35%
==========================================
Files 1200 1213 +13
Lines 119118 122483 +3365
==========================================
+ Hits 19021 19132 +111
- Misses 98143 101396 +3253
- Partials 1954 1955 +1
|
littlejiancc
force-pushed
the
feature/dop-sceneSet-arallel
branch
from
28afced to
95b2e4d
Compare
sfwn
requested changes
Sep 28, 2021
apistructs/sceneset.go
Outdated
| SceneSetsAutotestExecType = "sceneSets" | ||
| SceneAutotestExecType = "scene" | ||
|
|
||
| nameMaxLength int = 50 |
modules/dop/dao/testplan_v2_step.go
Outdated
| var step, nextStep TestPlanV2Step | ||
| defer func() error { |
There was a problem hiding this comment.
Wrong usage of defer function with error. You never have chance to handle defer error.
Should change to:
return client.Transaction(func(tx *grom.DB) (err error) {
defer func() {
if err == nil {
err = updateStepGroup(tx, step.GroupID)
}
}
}
modules/dop/dao/testplan_v2_step.go
Outdated
| return client.Transaction(func(tx *gorm.DB) (err error) { | ||
| var oldGroupID, newGroupID uint64 | ||
| // update step groupID in the group if isGroup is false | ||
| defer func() error { |
modules/dop/endpoints/endpoints.go
Outdated
| @@ -407,6 +407,7 @@ func (e *Endpoints) Routes() []httpserver.Endpoint { | |||
| {Path: "/api/autotests/testplans/{testPlanID}/actions/move-step", Method: http.MethodPut, Handler: e.MoveTestPlanV2Step}, | |||
| {Path: "/api/autotests/testplans-step/{stepID}", Method: http.MethodGet, Handler: e.GetTestPlanV2Step}, | |||
| {Path: "/api/autotests/testplans-step/{stepID}", Method: http.MethodPut, Handler: e.UpdateTestPlanV2Step}, | |||
| {Path: "/api/autotests/testplans-steps/{testPlanID}/actions/by-groupID", Method: http.MethodGet, Handler: e.ListTestPlanV2Step}, | |||
There was a problem hiding this comment.
bad restful api.
maybe /api/autotests/testplans/{testPlanID}/steps/actions/list-by-group-id
littlejiancc
force-pushed
the
feature/dop-sceneSet-arallel
branch
from
58bb27e to
2914ee6
Compare
sfwn
previously approved these changes
Oct 15, 2021
|
/approve |
erda-bot
approved these changes
Oct 15, 2021
|
/cherry-pick release/1.3 |
erda-bot
pushed a commit
to erda-bot/erda
that referenced
this pull request
Oct 15, 2021
* feature: scene set supports parallel in autoTest * add ListTestPlanV2Step api * update move group * add split op of render * fix: add unit test * add unit test * add unit test for render * add migrations * polish code * fix: update timeout of Test_initCron
johnlanni
pushed a commit
that referenced
this pull request
Oct 16, 2021
* feature: scene set supports parallel in autoTest * add ListTestPlanV2Step api * update move group * add split op of render * fix: add unit test * add unit test * add unit test for render * add migrations * polish code * fix: update timeout of Test_initCron Co-authored-by: littlejian <17816869670@163.com>
littlejiancc
added a commit
to littlejiancc/erda
that referenced
this pull request
Oct 18, 2021
…t#2173) (erda-project#2412)" This reverts commit cb7aafe.
Effet
added a commit
to Effet/erda
that referenced
this pull request
Oct 18, 2021
…t#2173) (erda-project#2412)" This reverts commit cb7aafe.
Effet
added a commit
that referenced
this pull request
Oct 18, 2021
|
/cherry-pick release/1.3 |
erda-bot
pushed a commit
to erda-bot/erda
that referenced
this pull request
Oct 19, 2021
* feature: scene set supports parallel in autoTest * add ListTestPlanV2Step api * update move group * add split op of render * fix: add unit test * add unit test * add unit test for render * add migrations * polish code * fix: update timeout of Test_initCron
erda-bot
added a commit
that referenced
this pull request
Oct 19, 2021
* feature: scene set supports parallel in autoTest * add ListTestPlanV2Step api * update move group * add split op of render * fix: add unit test * add unit test * add unit test for render * add migrations * polish code * fix: update timeout of Test_initCron Co-authored-by: littlejian <17816869670@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
/kind feature
What this PR does / why we need it:
feature: scene set supports parallel in autoTest
Which issue(s) this PR fixes:
自动化测试计划中，场景集支持并行
Specified Reviewers:
/assign @sfwn
ChangeLog
Need cherry-pick to release versions?
/cherry-pick release/1.3
Add comment like
/cherry-pick release/1.0when this PR is merged.