-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: solve the problem of getting nil context in the goroutine caused by the context being recycled #2348
Merged
hoozecn
merged 1 commit into
erda-project:master
from
littlejiancc:feature/gittar-bugfix
Oct 13, 2021
Merged
fix: solve the problem of getting nil context in the goroutine caused by the context being recycled #2348
hoozecn
merged 1 commit into
erda-project:master
from
littlejiancc:feature/gittar-bugfix
Oct 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2348 +/- ##
==========================================
- Coverage 15.92% 15.90% -0.02%
==========================================
Files 1193 1195 +2
Lines 118011 118228 +217
==========================================
+ Hits 18794 18810 +16
- Misses 97242 97500 +258
+ Partials 1975 1918 -57
|
… by the context being recycled
littlejiancc
force-pushed
the
feature/gittar-bugfix
branch
from
October 12, 2021 13:09
63027df
to
3d8bc8e
Compare
hoozecn
approved these changes
Oct 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/cherry-pick release/1.3 |
Automated cherry pick can ONLY be triggered when this PR is MERGED! |
/cherry-pick release/1.3 |
erda-bot
pushed a commit
to erda-bot/erda
that referenced
this pull request
Oct 13, 2021
… by the context being recycled (erda-project#2348)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… by the context being recycled
What type of this PR
/kind bug
What this PR does / why we need it:
When use context of echo in the goroutine, if another request coming when the goroutine is not finish, the context will be recycled, so the context is nil.
Which issue(s) this PR fixes:
Specified Reviewers:
/assign @sfwn
ChangeLog
Need cherry-pick to release versions?
Add comment like
/cherry-pick release/1.0
when this PR is merged.