Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #2306: feature: Optimize checker for HTTP mode #2377

Conversation

erda-bot
Copy link
Member

Cherry pick of #2306 on release/1.3.

Squashed commit message:

commit f949d2244118dc9d4899a5c21819418336a0f7c4
Author: innerpeacez <innerpeace.zhai@gmail.com>
Date:   Thu Oct 14 10:56:57 2021 +0800

    feature: Optimize checker for HTTP mode (#2306)
    
    * add column config
    
    * change checker api
    
    * change checker api (proto-go)
    
    * impl checker for HTTP method
    
    * fix go imports
    
    * add ut for triggering.go (TestNew TestTriggering_Executor TestTriggering_BodyStrategy TestTriggering_HttpCodeStrategy)
    
    * go imports format
    
    * checker api fix
    
    * fix ut

What type of this PR

Add one of the following kinds:
/kind feature

What this PR does / why we need it:

  • optimize checker for HTTP mode

Specified Reviewers:

/assign @liuhaoyang

ChangeLog

Language Changelog
🇺🇸 English Optimize checker for HTTP mode
🇨🇳 中文 优化主动监控 HTTP 检查模式

* add column config

* change checker api

* change checker api (proto-go)

* impl checker for HTTP method

* fix go imports

* add ut for triggering.go (TestNew TestTriggering_Executor TestTriggering_BodyStrategy TestTriggering_HttpCodeStrategy)

* go imports format

* checker api fix

* fix ut
@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #2377 (f949d22) into release/1.3 (c78c901) will increase coverage by 0.03%.
The diff coverage is 46.34%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/1.3    #2377      +/-   ##
===============================================
+ Coverage        16.09%   16.12%   +0.03%     
===============================================
  Files             1180     1182       +2     
  Lines           116666   116807     +141     
===============================================
+ Hits             18776    18834      +58     
- Misses           95942    96070     +128     
+ Partials          1948     1903      -45     
Impacted Files Coverage Δ
modules/dop/initialize.go 5.81% <0.00%> (-0.06%) ⬇️
modules/msp/apm/checker/apis/checker.v1.service.go 0.00% <0.00%> (ø)
.../apm/checker/plugins/http/triggering/triggering.go 86.79% <86.79%> (ø)
...rotocol/components/issue-dashboard/total/render.go 42.10% <91.66%> (ø)
modules/cmp/steve/middleware/dispatcher.go 52.89% <0.00%> (-4.35%) ⬇️
modules/cmp/metrics/metrics.go 23.47% <0.00%> (-1.88%) ⬇️
.../cmp-dashboard-workload-detail/podsTable/render.go 23.20% <0.00%> (-1.61%) ⬇️
.../components/cmp-dashboard-nodes/cpuTable/render.go 13.29% <0.00%> (-0.58%) ⬇️
modules/cmp/steve/middleware/audit.go 31.87% <0.00%> (-0.43%) ⬇️
... and 3 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants