-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: eventbox support custom notify channel #2460
Merged
liuhaoyang
merged 7 commits into
erda-project:master
from
snakorse:feature/eventbox-sms-channel
Nov 1, 2021
Merged
feature: eventbox support custom notify channel #2460
liuhaoyang
merged 7 commits into
erda-project:master
from
snakorse:feature/eventbox-sms-channel
Nov 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2460 +/- ##
==========================================
+ Coverage 15.91% 16.76% +0.84%
==========================================
Files 1218 1261 +43
Lines 123507 128242 +4735
==========================================
+ Hits 19656 21496 +1840
- Misses 101827 104536 +2709
- Partials 2024 2210 +186
|
liuhaoyang
approved these changes
Nov 1, 2021
/cherry-pick release/1.4 |
erda-bot
pushed a commit
to erda-bot/erda
that referenced
this pull request
Nov 1, 2021
* feature: eventbox support custom notify channel * bugfix: change notify channel response struct * optimize: add unit test. * optimize: change channel provider name. * optimize: unit test naming * optimize: add etcd cert file env * optimize: add unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Add one of the following kinds:
/kind feature
What this PR does / why we need it:
feature: eventbox support custom notify channel
Specified Reviewers:
/assign @liuhaoyang @innerpeacez
ChangeLog