-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add unique key to dice_app
#2611
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automated cherry pick can ONLY be triggered when this PR is MERGED! |
littlejiancc
force-pushed
the
feature/app-create
branch
from
October 27, 2021 09:58
8b29d69
to
b72d12a
Compare
Codecov Report
@@ Coverage Diff @@
## master #2611 +/- ##
==========================================
+ Coverage 16.38% 16.41% +0.03%
==========================================
Files 1258 1259 +1
Lines 127651 127706 +55
==========================================
+ Hits 20915 20964 +49
- Misses 104585 104586 +1
- Partials 2151 2156 +5
|
sfwn
approved these changes
Oct 27, 2021
/approve |
erda-bot
approved these changes
Oct 27, 2021
/cherry-pick release/1.4 |
erda-bot
pushed a commit
to erda-bot/erda
that referenced
this pull request
Oct 27, 2021
erda-bot
added a commit
that referenced
this pull request
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
/kind bug
What this PR does / why we need it:
fix: add unique key to
dice_app
Which issue(s) this PR fixes:
Specified Reviewers:
/assign @sfwn
ChangeLog
Need cherry-pick to release versions?
/cherry-pick release/1.4
Add comment like
/cherry-pick release/1.0
when this PR is merged.