Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: early return when repo delete failed #2613

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

littlejiancc
Copy link
Contributor

What type of this PR

/kind bug

What this PR does / why we need it:

fix: early return when repo delete failed

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @sfwn

ChangeLog

Language Changelog
🇺🇸 English
🇨🇳 中文

Need cherry-pick to release versions?

/cherry-pick release/1.4

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot
Copy link
Member

Automated cherry pick can ONLY be triggered when this PR is MERGED!

@erda-bot erda-bot requested a review from sfwn October 27, 2021 10:08
@littlejiancc littlejiancc added the dop devops plaoform label Oct 27, 2021
@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #2613 (3f0c096) into master (4d5fc52) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2613      +/-   ##
==========================================
+ Coverage   16.38%   16.41%   +0.03%     
==========================================
  Files        1258     1259       +1     
  Lines      127651   127706      +55     
==========================================
+ Hits        20915    20964      +49     
- Misses     104585   104586       +1     
- Partials     2151     2156       +5     
Impacted Files Coverage Δ
pkg/parser/pipelineyml/visitor_ref_op.go 46.23% <0.00%> (-0.54%) ⬇️
modules/admin/manager/cluster.go 13.41% <0.00%> (-0.10%) ⬇️
modules/admin/manager/permission.go 78.57% <0.00%> (ø)
pkg/mock/mock.go 45.45% <0.00%> (+4.04%) ⬆️
modules/admin/manager/id.go 70.58% <0.00%> (+70.58%) ⬆️

@sfwn
Copy link
Member

sfwn commented Oct 27, 2021

/approve

@erda-bot erda-bot merged commit f1cca15 into erda-project:master Oct 27, 2021
@sfwn
Copy link
Member

sfwn commented Oct 27, 2021

/cherry-pick release/1.4

erda-bot pushed a commit to erda-bot/erda that referenced this pull request Oct 27, 2021
erda-bot added a commit that referenced this pull request Oct 27, 2021
Co-authored-by: littlejian <17816869670@163.com>
@littlejiancc littlejiancc deleted the feature/app-delete branch October 27, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dop devops plaoform
Development

Successfully merging this pull request may close these issues.

3 participants