Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin access to the workbench no longer query all organization information #2692

Merged
merged 15 commits into from
Oct 30, 2021

Conversation

kakj-go
Copy link
Contributor

@kakj-go kakj-go commented Oct 29, 2021

What type of this PR

/kind bug

What this PR does / why we need it:

When the admin account enters the workbench, all organizations will be queried, and subsequent admin access to these organizations will not pass the verification authority.

Which issue(s) this PR fixes:

ChangeLog

Language Changelog
🇺🇸 English The admin account no longer queries all organizations
🇨🇳 中文 admin 账号不再查询所有组织

Need cherry-pick to release versions?

/cherry-pick release/1.4

@erda-bot
Copy link
Member

Automated cherry pick can ONLY be triggered when this PR is MERGED!

@kakj-go kakj-go requested a review from Effet October 29, 2021 08:37
@kakj-go kakj-go force-pushed the feature/admin-query-org branch from 40ac17b to cd63805 Compare October 29, 2021 08:38
@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #2692 (acd2ffc) into master (11e5f9c) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2692      +/-   ##
==========================================
+ Coverage   16.65%   16.68%   +0.02%     
==========================================
  Files        1263     1261       -2     
  Lines      128416   128176     -240     
==========================================
- Hits        21388    21385       -3     
+ Misses     104815   104597     -218     
+ Partials     2213     2194      -19     
Impacted Files Coverage Δ
apistructs/org.go 0.00% <ø> (ø)
modules/core-services/services/org/org.go 7.89% <100.00%> (+2.48%) ⬆️
modules/cmp/cache/cache.go 50.86% <0.00%> (-13.70%) ⬇️
modules/core-services/services/project/project.go 9.93% <0.00%> (-0.35%) ⬇️
modules/cmp/steve/server.go 0.00% <0.00%> (ø)
modules/cmp/steve/aggregator.go 0.00% <0.00%> (ø)
modules/cmp/steve/proxy/cache_store.go
modules/cmp/steve/proxy/error_wrapper.go
modules/cmp/steve/proxy/proxy_store.go
...nitor/storekit/kafka/topic/initializer/provider.go 32.72% <0.00%> (ø)
... and 5 more

@kakj-go kakj-go force-pushed the feature/admin-query-org branch 2 times, most recently from 558d91c to 0c10325 Compare October 29, 2021 11:24
@kakj-go kakj-go force-pushed the feature/admin-query-org branch from 0c10325 to acd2ffc Compare October 29, 2021 12:03
@Effet Effet merged commit b82d850 into erda-project:master Oct 30, 2021
@Effet
Copy link
Member

Effet commented Oct 30, 2021

/cherry-pick release/1.4

erda-bot pushed a commit to erda-bot/erda that referenced this pull request Oct 30, 2021
…ation (erda-project#2692)

* update projectID to projectId (erda-project#2534)

* admin access to the workbench no longer query all organization information

Co-authored-by: littlejian <17816869670@163.com>
erda-bot added a commit that referenced this pull request Oct 30, 2021
…ation (#2692) (#2708)

* update projectID to projectId (#2534)

* admin access to the workbench no longer query all organization information

Co-authored-by: littlejian <17816869670@163.com>

Co-authored-by: kakj <18579115540@163.com>
Co-authored-by: littlejian <17816869670@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants