-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
admin access to the workbench no longer query all organization information #2692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automated cherry pick can ONLY be triggered when this PR is MERGED! |
kakj-go
force-pushed
the
feature/admin-query-org
branch
from
October 29, 2021 08:38
40ac17b
to
cd63805
Compare
Codecov Report
@@ Coverage Diff @@
## master #2692 +/- ##
==========================================
+ Coverage 16.65% 16.68% +0.02%
==========================================
Files 1263 1261 -2
Lines 128416 128176 -240
==========================================
- Hits 21388 21385 -3
+ Misses 104815 104597 -218
+ Partials 2213 2194 -19
|
kakj-go
force-pushed
the
feature/admin-query-org
branch
2 times, most recently
from
October 29, 2021 11:24
558d91c
to
0c10325
Compare
kakj-go
force-pushed
the
feature/admin-query-org
branch
from
October 29, 2021 12:03
0c10325
to
acd2ffc
Compare
Effet
approved these changes
Oct 30, 2021
/cherry-pick release/1.4 |
erda-bot
pushed a commit
to erda-bot/erda
that referenced
this pull request
Oct 30, 2021
…ation (erda-project#2692) * update projectID to projectId (erda-project#2534) * admin access to the workbench no longer query all organization information Co-authored-by: littlejian <17816869670@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
/kind bug
What this PR does / why we need it:
When the admin account enters the workbench, all organizations will be queried, and subsequent admin access to these organizations will not pass the verification authority.
Which issue(s) this PR fixes:
ChangeLog
Need cherry-pick to release versions?
/cherry-pick release/1.4