-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify alert expression and add condition #2739
Merged
liuhaoyang
merged 30 commits into
erda-project:master
from
Counterflowwind:expression_and_condition
Nov 2, 2021
Merged
modify alert expression and add condition #2739
liuhaoyang
merged 30 commits into
erda-project:master
from
Counterflowwind:expression_and_condition
Nov 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndition # Conflicts: # conf/monitor/monitor/monitor.yaml
Codecov Report
@@ Coverage Diff @@
## master #2739 +/- ##
==========================================
- Coverage 16.92% 16.86% -0.06%
==========================================
Files 1270 1276 +6
Lines 128918 130070 +1152
==========================================
+ Hits 21818 21940 +122
- Misses 104852 105855 +1003
- Partials 2248 2275 +27
|
liuhaoyang
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Add one of the following kinds:
/kind feature
ChangeLog