Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify alert expression and add condition #2739

Merged

Conversation

Counterflowwind
Copy link
Contributor

What type of this PR

Add one of the following kinds:
/kind feature

ChangeLog

Language Changelog
🇺🇸 English 增加告警触发条件,修改告警表达式
🇨🇳 中文 Added alarm trigger conditions and modified alarm expressions

@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #2739 (d2cd603) into master (94d314d) will decrease coverage by 0.05%.
The diff coverage is 43.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2739      +/-   ##
==========================================
- Coverage   16.92%   16.86%   -0.06%     
==========================================
  Files        1270     1276       +6     
  Lines      128918   130070    +1152     
==========================================
+ Hits        21818    21940     +122     
- Misses     104852   105855    +1003     
- Partials     2248     2275      +27     
Impacted Files Coverage Δ
modules/cmp/provider.go 14.81% <0.00%> (ø)
.../core/monitor/alert/alert-apis/adapt/expression.go 33.12% <ø> (+4.45%) ⬆️
modules/msp/apm/alert/alert.go 0.00% <ø> (ø)
modules/msp/apm/alert/provider.go 10.34% <0.00%> (-0.37%) ⬇️
modules/msp/apm/alert/alert.service.go 13.13% <28.76%> (+2.04%) ⬆️
...dules/core/monitor/alert/alert-apis/adapt/alert.go 16.87% <42.42%> (+3.01%) ⬆️
modules/cmp/alert.go 63.63% <63.63%> (ø)
...re/monitor/alert/alert-apis/adapt/alert_convert.go 32.74% <71.42%> (+7.84%) ⬆️
modules/cmp/metricsImpl.go 0.00% <0.00%> (ø)
modules/cmp/cluster_resource.go 0.00% <0.00%> (ø)
... and 6 more

@Counterflowwind Counterflowwind added msp microsevice platform feature labels Nov 1, 2021
@liuhaoyang liuhaoyang merged commit 13539c0 into erda-project:master Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature msp microsevice platform
Development

Successfully merging this pull request may close these issues.

2 participants