Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: event query support tags filter #2772

Merged

Conversation

snakorse
Copy link
Contributor

@snakorse snakorse commented Nov 2, 2021

What type of this PR

Add one of the following kinds:
/kind feature

What this PR does / why we need it:

feature: event query support tags filter

Specified Reviewers:

/assign @liuhaoyang

ChangeLog

Language Changelog
🇺🇸 English
🇨🇳 中文

Need cherry-pick to release versions?

/cherry-pick release/1.4

@snakorse snakorse added msp microsevice platform feature labels Nov 2, 2021
@erda-bot
Copy link
Member

erda-bot commented Nov 2, 2021

Automated cherry pick can ONLY be triggered when this PR is MERGED!

@erda-bot erda-bot requested a review from liuhaoyang November 2, 2021 05:34
@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #2772 (5fa22f2) into master (3a69a17) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2772      +/-   ##
==========================================
- Coverage   16.97%   16.93%   -0.04%     
==========================================
  Files        1273     1279       +6     
  Lines      129093   130260    +1167     
==========================================
+ Hits        21915    22064     +149     
- Misses     104887   105795     +908     
- Partials     2291     2401     +110     
Impacted Files Coverage Δ
...es/core/monitor/event/query/event.query.service.go 78.43% <100.00%> (+7.97%) ⬆️
modules/msp/apm/alert/provider.go 10.34% <0.00%> (-0.37%) ⬇️
modules/msp/apm/alert/alert.go 0.00% <0.00%> (ø)
modules/cmp/initialize.go 0.00% <0.00%> (ø)
modules/cmp/steve_request.go 0.49% <0.00%> (ø)
modules/cmp/metricsImpl.go 0.00% <0.00%> (ø)
modules/cmp/cluster_resource.go 0.00% <0.00%> (ø)
modules/cmp/alert.go 63.63% <0.00%> (ø)
modules/cmp/provider.go 14.81% <0.00%> (ø)
.../core/monitor/alert/alert-apis/adapt/expression.go 29.11% <0.00%> (+0.45%) ⬆️
... and 4 more

@liuhaoyang liuhaoyang merged commit 5e3aebd into erda-project:master Nov 2, 2021
@snakorse
Copy link
Contributor Author

snakorse commented Nov 2, 2021

/cherry-pick release/1.4

erda-bot pushed a commit to erda-bot/erda that referenced this pull request Nov 2, 2021
erda-bot added a commit that referenced this pull request Nov 2, 2021
Co-authored-by: 郭刚平 <512979011@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature msp microsevice platform
Development

Successfully merging this pull request may close these issues.

3 participants