Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify customize alert rule #2860

Conversation

Counterflowwind
Copy link
Contributor

What type of this PR

Add one of the following kinds:
/kind bugfix

ChangeLog

Language Changelog
🇺🇸 English Fix the bug that the custom alarm filtering rules created by msp and cmp are incorrect
🇨🇳 中文 修复msp和cmp创建自定义告警过滤规则不正确的问题

@Counterflowwind Counterflowwind added msp microsevice platform bugfix labels Nov 4, 2021
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #2860 (f98a710) into master (7ccf7be) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2860      +/-   ##
==========================================
+ Coverage   17.06%   17.10%   +0.04%     
==========================================
  Files        1286     1292       +6     
  Lines      131279   131579     +300     
==========================================
+ Hits        22399    22507     +108     
- Misses     106564   106728     +164     
- Partials     2316     2344      +28     
Impacted Files Coverage Δ
modules/msp/apm/alert/alert.service.go 14.15% <ø> (+1.02%) ⬆️
pkg/mock/mock.go 40.40% <0.00%> (-5.06%) ⬇️
modules/dop/provider.go 9.52% <0.00%> (-0.24%) ⬇️
...estrator/services/deployment/deployment_context.go 9.25% <0.00%> (-0.17%) ⬇️
pkg/dlock/dlock.go 0.00% <0.00%> (ø)
modules/cmp/initialize.go 0.00% <0.00%> (ø)
modules/cmp/steve/schema.go 0.00% <0.00%> (ø)
modules/cmp/steve/server.go 0.00% <0.00%> (ø)
modules/orchestrator/events/events.go 0.00% <0.00%> (ø)
...odules/orchestrator/services/addon/addon_tenant.go 0.00% <0.00%> (ø)
... and 12 more

@liuhaoyang liuhaoyang merged commit acf3f15 into erda-project:master Nov 4, 2021
@liuhaoyang
Copy link
Contributor

/cherry-pick release/1.4

erda-bot pushed a commit to erda-bot/erda that referenced this pull request Nov 4, 2021
erda-bot added a commit that referenced this pull request Nov 4, 2021
Co-authored-by: panjiayao <44628544+Counterflowwind@users.noreply.github.com>
Counterflowwind added a commit to Counterflowwind/erda that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix msp microsevice platform
Development

Successfully merging this pull request may close these issues.

2 participants