Feat msp storage switch to es #2861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2861 +/- ##
==========================================
+ Coverage 17.09% 17.27% +0.17%
==========================================
Files 1292 1301 +9
Lines 131580 132388 +808
==========================================
+ Hits 22498 22873 +375
- Misses 106759 107151 +392
- Partials 2323 2364 +41
|
recallsong
reviewed
Nov 4, 2021
| indices := p.Loader.Indices(ctx, sel.StartTime, sel.EndTime, loader.KeyPath{ | ||
| Recursive: true, | ||
| }) | ||
| fmt.Println(indices) |
| "github.com/erda-project/erda/modules/msp/apm/exception/erda-error/storage" | ||
| ) | ||
|
|
||
| // Data . |
| // Data . | ||
| type Error = interface{} | ||
|
|
||
| // ListIterator . |
| } | ||
|
|
||
| // NewListIterator . | ||
| func NewErrorListIterator(list ...Error) storekit.Iterator { |
| } | ||
|
|
||
| func (it *scrollIterator) fetch(dir iteratorDir) error { | ||
| fmt.Println(it.indices) |
| @@ -90,7 +90,7 @@ func (p *provider) Close() error { | |||
| func init() { | |||
| servicehub.Register("trace-storage", &servicehub.Spec{ | |||
| Services: []string{"trace-storage"}, | |||
| Dependencies: []string{"kafka", "cassandra", "kafka.topic.initializer"}, | |||
| Dependencies: []string{"kafka", "cassandra"}, | |||
There was a problem hiding this comment.
why delete kafka.topic.initializer
|
Adjust your changelog into table please. |
|
/approve |
erda-bot
approved these changes
Nov 5, 2021
|
/cherry-pick release/1.4 |
erda-bot
pushed a commit
to erda-bot/erda
that referenced
this pull request
Nov 5, 2021
* feature: msp storage switch to es * bugifx: msp fix queryspanbytraceid bug * feature-msp-storage-support-es&bugfix-msp-span-lost * fix ci go-import order problem * fix queryspancountbytraceid bug * fix code review problem from recallsong * fix ci check-imports problem * fix ci fmt problem * fix ci fmt problem again, sadly * change span es index shards default setting to 1
erda-bot
added a commit
that referenced
this pull request
Nov 5, 2021
* feature: msp storage switch to es * bugifx: msp fix queryspanbytraceid bug * feature-msp-storage-support-es&bugfix-msp-span-lost * fix ci go-import order problem * fix queryspancountbytraceid bug * fix code review problem from recallsong * fix ci check-imports problem * fix ci fmt problem * fix ci fmt problem again, sadly * change span es index shards default setting to 1 Co-authored-by: li2329800 <9552289+li2329800@users.noreply.github.com>
liuhaoyang
pushed a commit
that referenced
this pull request
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Add one of the following kinds:
/kind feature
/kind bugfix
What this PR does / why we need it:
Which issue(s) this PR fixes:
Specified Reviewers:
/assign @liuhaoyang @recallsong
ChangeLog
2. Support ES as beckend storage in msp platform
2.实现了msp平台后端存储对于ES的支持
Need cherry-pick to release versions?
Need cherry-pick to release/1.4