Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autotest not set bootstrap token #2991

Merged

Conversation

kakj-go
Copy link
Contributor

@kakj-go kakj-go commented Nov 10, 2021

What type of this PR

/kind feature

What this PR does / why we need it:

Bootstrap token is no longer set for automated testing. In automated testing, a large number of interfaces to apply for tokens cause excessive pressure on the openapi interface, and the applied tokens are useless

Which issue(s) this PR fixes:

ChangeLog

Language Changelog
🇺🇸 English Pipeline special judgment api-test, wait and snippet type actions no longer apply for bootstrap token
🇨🇳 中文 pipeline 特殊判断api-test,wait和snippet类型的action不再申请 bootstrap token

Need cherry-pick to release versions?

/cherry-pick release/1.4

@erda-bot
Copy link
Member

Automated cherry pick can ONLY be triggered when this PR is MERGED!

@kakj-go kakj-go force-pushed the feature/autotest-not-set-bootstrap-token branch from 0410149 to 9af5e42 Compare November 10, 2021 06:41
@kakj-go kakj-go added pipeline pipeline service bug labels Nov 10, 2021
@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #2991 (a2797b4) into master (d2121ba) will increase coverage by 0.03%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2991      +/-   ##
==========================================
+ Coverage   17.58%   17.61%   +0.03%     
==========================================
  Files        1325     1326       +1     
  Lines      135083   135129      +46     
==========================================
+ Hits        23750    23800      +50     
+ Misses     108887   108879       -8     
- Partials     2446     2450       +4     
Impacted Files Coverage Δ
modules/pipeline/pipengine/reconciler/reconcile.go 0.00% <0.00%> (ø)
...ine/pipengine/reconciler/taskrun/taskop/prepare.go 0.66% <100.00%> (+0.66%) ⬆️
modules/cmp/resource/report_table.go 11.57% <0.00%> (-0.61%) ⬇️
...dules/core/monitor/alert/alert-apis/adapt/alert.go 16.56% <0.00%> (-0.32%) ⬇️
...ponents/cmp-dashboard-events-list/filter/render.go 15.12% <0.00%> (-0.15%) ⬇️
...ents/cmp-dashboard-workloads-list/filter/render.go 12.93% <0.00%> (-0.12%) ⬇️
modules/cmp/tasks/collect_daily_quota.go 8.13% <0.00%> (-0.10%) ⬇️
modules/dop/services/project/get.go 0.00% <0.00%> (ø)
pkg/http/httpclient/request_setter.go 100.00% <0.00%> (ø)
... and 3 more

@kakj-go kakj-go force-pushed the feature/autotest-not-set-bootstrap-token branch from 9af5e42 to a2797b4 Compare November 10, 2021 11:09
@kakj-go kakj-go marked this pull request as draft November 10, 2021 11:12
@kakj-go kakj-go marked this pull request as ready for review November 10, 2021 11:12
@sfwn
Copy link
Member

sfwn commented Nov 10, 2021

/approve

@sfwn
Copy link
Member

sfwn commented Nov 10, 2021

/cherry-pick release/1.4

@erda-bot erda-bot merged commit eb00dd6 into erda-project:master Nov 10, 2021
erda-bot pushed a commit to erda-bot/erda that referenced this pull request Nov 10, 2021
erda-bot added a commit that referenced this pull request Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants