Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shared http transport #3014

Merged

Conversation

recallsong
Copy link
Contributor

What type of this PR

/kind bugfix
/kind polish

What this PR does / why we need it:

shared http transport

Specified Reviewers:

/assign @johnlanni

Need cherry-pick to release versions?

/cherry-pick release/1.4

@erda-bot
Copy link
Member

Automated cherry pick can ONLY be triggered when this PR is MERGED!

@erda-bot erda-bot requested a review from johnlanni November 11, 2021 04:14
@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #3014 (06d1c1a) into master (eb54891) will decrease coverage by 0.03%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3014      +/-   ##
==========================================
- Coverage   17.65%   17.62%   -0.04%     
==========================================
  Files        1327     1327              
  Lines      135271   135272       +1     
==========================================
- Hits        23882    23840      -42     
- Misses     108875   108980     +105     
+ Partials     2514     2452      -62     
Impacted Files Coverage Δ
modules/extensions/loghub/index/query/clients.go 41.02% <0.00%> (ø)
pkg/http/httpclient/request.go 27.47% <ø> (ø)
pkg/http/httpclient/trace.go 0.00% <0.00%> (ø)
pkg/http/httpclient/client.go 29.28% <57.14%> (+4.28%) ⬆️
...e/pipengine/reconciler/queuemanage/manager/stop.go 62.50% <0.00%> (-37.50%) ⬇️
...-test-scenes/components/executeTaskTable/render.go 29.74% <0.00%> (-4.12%) ⬇️
modules/cmp/steve/middleware/dispatcher.go 48.93% <0.00%> (-3.89%) ⬇️
...-plan-detail/components/executeTaskTable/render.go 46.11% <0.00%> (-2.34%) ⬇️
modules/core-services/services/project/project.go 14.28% <0.00%> (-1.11%) ⬇️
modules/pipeline/pipengine/reconciler/reconcile.go 0.00% <0.00%> (ø)
... and 1 more

@johnlanni
Copy link
Contributor

/approve

@erda-bot erda-bot merged commit c8c2454 into erda-project:master Nov 11, 2021
@johnlanni
Copy link
Contributor

/cherry-pick release/1.4

erda-bot pushed a commit to erda-bot/erda that referenced this pull request Nov 11, 2021
* shared http transport

* disable connection pool
erda-bot added a commit that referenced this pull request Nov 11, 2021
* shared http transport

* disable connection pool

Co-authored-by: RecallSong <13607438+recallsong@users.noreply.github.com>
kakj-go pushed a commit to kakj-go/erda that referenced this pull request Nov 12, 2021
* shared http transport

* disable connection pool
kakj-go pushed a commit to kakj-go/erda that referenced this pull request Nov 12, 2021
* shared http transport

* disable connection pool
erda-bot pushed a commit that referenced this pull request Nov 16, 2021
* shared http transport (#3014)

* shared http transport

* disable connection pool

* not permission return project name and app name

Co-authored-by: RecallSong <13607438+recallsong@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants