split the result filed to metadata and inspect #3043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengjoey
force-pushed
the
fix/pipeline-metadata-missed
branch
from
9937bd7 to
f52119f
Compare
Codecov Report
@@ Coverage Diff @@
## master #3043 +/- ##
==========================================
+ Coverage 17.37% 17.40% +0.02%
==========================================
Files 1361 1361
Lines 140447 140449 +2
==========================================
+ Hits 24401 24441 +40
+ Misses 113500 113474 -26
+ Partials 2546 2534 -12
|
chengjoey
force-pushed
the
fix/pipeline-metadata-missed
branch
2 times, most recently
from
817c577 to
0d670f0
Compare
|
convert to pipeline task dto: |
chengjoey
force-pushed
the
fix/pipeline-metadata-missed
branch
3 times, most recently
from
3e321a9 to
549a654
Compare
sfwn
requested changes
Nov 18, 2021
| @@ -0,0 +1 @@ | |||
| ALTER TABLE `pipeline_tasks` ADD COLUMN `inspect` text COMMENT 'task的调度信息' AFTER `result`; | |||
| @@ -62,6 +62,7 @@ type TaskContainer struct { | |||
| ContainerID string `json:"containerID"` | |||
| } | |||
|
|
|||
| // PipelineTaskResult spec.pipeline task only use metadata, task dto has all fields | |||
| type PipelineTaskResult struct { | |||
| Metadata Metadata `json:"metadata,omitempty"` | |||
| Errors []*PipelineTaskErrResponse `json:"errors,omitempty"` | |||
| @@ -195,7 +203,7 @@ func (o orderedResponses) Len() int { return len(o) } | |||
| func (o orderedResponses) Less(i, j int) bool { return o[i].Ctx.EndTime.Before(o[j].Ctx.EndTime) } | |||
| func (o orderedResponses) Swap(i, j int) { o[i], o[j] = o[j], o[i] } | |||
|
|
|||
| func (t *PipelineTaskResult) AppendError(newResponses ...*PipelineTaskErrResponse) []*PipelineTaskErrResponse { | |||
| func (t *PipelineTaskInspect) AppendError(newResponses ...*PipelineTaskErrResponse) []*PipelineTaskErrResponse { | |||
| meta := latestTask.Result.Metadata | ||
| var meta apistructs.Metadata | ||
| if latestTask.Result != nil { | ||
| meta = (*latestTask.Result).Metadata |
There was a problem hiding this comment.
add a function for spec.task to get metadata.
judge nil each time is bad.
chengjoey
force-pushed
the
fix/pipeline-metadata-missed
branch
from
549a654 to
57a87aa
Compare
chengjoey
force-pushed
the
fix/pipeline-metadata-missed
branch
from
57a87aa to
f1c18b8
Compare
sfwn
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Add one of the following kinds:
/kind bugfix
What this PR does / why we need it:
split the result filed to metadata and inspect, update metadata only when task callback
Which issue(s) this PR fixes:
Specified Reviewers:
/assign @your-reviewer
ChangeLog
Need cherry-pick to release versions?
Add comment like
/cherry-pick release/1.0when this PR is merged.