Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto test space list pageNo reset #3064

Merged
merged 3 commits into from
Nov 16, 2021

Conversation

shuofan
Copy link
Contributor

@shuofan shuofan commented Nov 16, 2021

What type of this PR

bugfix

What this PR does / why we need it:

Fix auto test space list pageNo reset

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @sfwn

ChangeLog

Language Changelog
🇺🇸 English
🇨🇳 中文

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot requested a review from sfwn November 16, 2021 07:51
@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #3064 (3acd2d1) into master (2b74052) will increase coverage by 0.00%.
The diff coverage is 21.42%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3064   +/-   ##
=======================================
  Coverage   17.23%   17.23%           
=======================================
  Files        1353     1353           
  Lines      139564   139547   -17     
=======================================
  Hits        24055    24055           
+ Misses     113044   113027   -17     
  Partials     2465     2465           
Impacted Files Coverage Δ
apistructs/audits.go 0.00% <ø> (ø)
apistructs/autotest_space.go 53.84% <0.00%> (-18.57%) ⬇️
modules/dop/services/autotest_v2/space.go 6.69% <75.00%> (+0.02%) ⬆️
modules/hepa/services/domain/impl/impl.go 1.82% <0.00%> (+0.04%) ⬆️

@shuofan shuofan force-pushed the bug/auto-test-space branch from b997eb1 to 8f7e083 Compare November 16, 2021 08:52
@shuofan shuofan added bugfix dop devops plaoform labels Nov 16, 2021
@sfwn
Copy link
Member

sfwn commented Nov 16, 2021

refactor audit template to i18n later.

@sfwn
Copy link
Member

sfwn commented Nov 16, 2021

/approve

@erda-bot erda-bot merged commit 95abb57 into erda-project:master Nov 16, 2021
@shuofan
Copy link
Contributor Author

shuofan commented Nov 16, 2021

/cherry-pick release/1.4.1

erda-bot pushed a commit to erda-bot/erda that referenced this pull request Nov 16, 2021
* Fix auto test space list pageNo reset

* Add audit templates

* Fix unit test
erda-bot added a commit that referenced this pull request Nov 16, 2021
* Fix auto test space list pageNo reset

* Add audit templates

* Fix unit test

Co-authored-by: shuofan <fanshuo2015@gmail.com>
@sfwn sfwn deleted the bug/auto-test-space branch November 16, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants