Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automated test plan pass rate display retains 2 decimal places #3065

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

kakj-go
Copy link
Contributor

@kakj-go kakj-go commented Nov 16, 2021

What type of this PR

/kind bugfix

What this PR does / why we need it:

The execution rate of the automated test plan does not retain 2 decimal places but uses %.f for the value, which will cause 99.89 to become 100, which leads to inconsistencies.

Which issue(s) this PR fixes:

ChangeLog

Language Changelog
🇺🇸 English automated test plan execution pass rate retains 2 decimal places
🇨🇳 中文 自动化测试计划执行通过率保留2位小数

Need cherry-pick to release versions?

/cherry-pick release/1.4

@erda-bot
Copy link
Member

Automated cherry pick can ONLY be triggered when this PR is MERGED!

@kakj-go kakj-go added dop devops plaoform bug labels Nov 16, 2021
@kakj-go
Copy link
Contributor Author

kakj-go commented Nov 16, 2021

test image:

image

@kakj-go kakj-go force-pushed the feature/plan-pass-rate branch from fd40033 to e42766e Compare November 16, 2021 08:04
@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #3065 (e42766e) into master (cfae0e1) will decrease coverage by 0.44%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3065      +/-   ##
==========================================
- Coverage   17.67%   17.23%   -0.45%     
==========================================
  Files        1327     1353      +26     
  Lines      135323   139564    +4241     
==========================================
+ Hits        23920    24055     +135     
- Misses     108948   113044    +4096     
- Partials     2455     2465      +10     
Impacted Files Coverage Δ
...ios/auto-test-plan-list/components/table/render.go 45.96% <100.00%> (ø)
...dules/scheduler/executor/plugins/k8s/deployment.go 32.13% <0.00%> (-0.59%) ⬇️
modules/dop/endpoints/autotests_space.go 14.50% <0.00%> (-0.16%) ⬇️
modules/dop/endpoints/scenesets.go 7.36% <0.00%> (-0.08%) ⬇️
modules/dop/services/autotest_v2/space.go 6.66% <0.00%> (-0.06%) ⬇️
...dashboard-workload-detail/yamlFileEditor/render.go 8.09% <0.00%> (-0.05%) ⬇️
modules/hepa/services/domain/impl/impl.go 1.77% <0.00%> (-0.02%) ⬇️
modules/cmp/provider.go 14.81% <0.00%> (ø)
apistructs/cluster_info.go 38.33% <0.00%> (ø)
modules/dop/endpoints/autotest_scene.go 0.00% <0.00%> (ø)
... and 43 more

@sfwn
Copy link
Member

sfwn commented Nov 17, 2021

/approve

@erda-bot erda-bot merged commit 82c5bd8 into erda-project:master Nov 17, 2021
@sfwn
Copy link
Member

sfwn commented Nov 17, 2021

/cherry-pick release/1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved bug dop devops plaoform
Development

Successfully merging this pull request may close these issues.

3 participants