-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
automated test plan pass rate display retains 2 decimal places #3065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automated cherry pick can ONLY be triggered when this PR is MERGED! |
kakj-go
force-pushed
the
feature/plan-pass-rate
branch
from
November 16, 2021 08:04
fd40033
to
e42766e
Compare
Codecov Report
@@ Coverage Diff @@
## master #3065 +/- ##
==========================================
- Coverage 17.67% 17.23% -0.45%
==========================================
Files 1327 1353 +26
Lines 135323 139564 +4241
==========================================
+ Hits 23920 24055 +135
- Misses 108948 113044 +4096
- Partials 2455 2465 +10
|
sfwn
approved these changes
Nov 17, 2021
/approve |
erda-bot
approved these changes
Nov 17, 2021
/cherry-pick release/1.4 |
erda-bot
pushed a commit
to erda-bot/erda
that referenced
this pull request
Nov 17, 2021
erda-bot
added a commit
that referenced
this pull request
Nov 17, 2021
#3080) Co-authored-by: kakj <18579115540@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
/kind bugfix
What this PR does / why we need it:
The execution rate of the automated test plan does not retain 2 decimal places but uses %.f for the value, which will cause 99.89 to become 100, which leads to inconsistencies.
Which issue(s) this PR fixes:
ChangeLog
Need cherry-pick to release versions?
/cherry-pick release/1.4