Fix/pipeline cron compensate #3119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3119 +/- ##
==========================================
- Coverage 17.37% 17.37% -0.01%
==========================================
Files 1361 1361
Lines 140447 140430 -17
==========================================
- Hits 24401 24397 -4
- Misses 113500 113537 +37
+ Partials 2546 2496 -50
|
chengjoey
force-pushed
the
fix/pipeline-cron-compensate
branch
from
1909618 to
98f3c6d
Compare
|
|
skoowoo
reviewed
Nov 22, 2021
| @@ -57,9 +57,13 @@ func (s *PipelineSvc) RunCronPipelineFunc(id uint64) { | |||
| } | |||
|
|
|||
| // 如果当前触发时间小于定时开始时间，return | |||
There was a problem hiding this comment.
translate into english, pls
chengjoey
force-pushed
the
fix/pipeline-cron-compensate
branch
from
98f3c6d to
bb43b5e
Compare
|
Adjust your Chinese changelog. |
sfwn
approved these changes
Nov 22, 2021
adjusted |
|
/cherry-pick release/1.4 release/1.3 |
erda-bot
pushed a commit
to erda-bot/erda
that referenced
this pull request
Dec 2, 2021
erda-bot
pushed a commit
to erda-bot/erda
that referenced
this pull request
Dec 2, 2021
erda-bot
added a commit
that referenced
this pull request
Dec 2, 2021
erda-bot
added a commit
that referenced
this pull request
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Add one of the following kinds:
/kind bugfix
What this PR does / why we need it:
cron compensator judge cron start time with trigger time
Which issue(s) this PR fixes:
Specified Reviewers:
/assign @your-reviewer
ChangeLog
Need cherry-pick to release versions?
Add comment like
/cherry-pick release/1.0when this PR is merged.