Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the bug of concurrent create snippet pipelines #3126

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

littlejiancc
Copy link
Contributor

@littlejiancc littlejiancc commented Nov 22, 2021

What type of this PR

/kind bugfix

What this PR does / why we need it:

fix the bug of concurrent create snippet pipelines

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @sfwn

ChangeLog

Language Changelog
🇺🇸 English
🇨🇳 中文

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot requested a review from sfwn November 22, 2021 11:39
@littlejiancc littlejiancc force-pushed the feature/pipeline-labels branch 3 times, most recently from 524da96 to b9e047f Compare November 22, 2021 12:21
@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #3126 (6259c3b) into master (0d67328) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 6259c3b differs from pull request most recent head 79373bf. Consider uploading reports for the commit 79373bf to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3126      +/-   ##
==========================================
+ Coverage   17.37%   17.42%   +0.04%     
==========================================
  Files        1361     1361              
  Lines      140423   140453      +30     
==========================================
+ Hits        24398    24467      +69     
+ Misses     113488   113456      -32     
+ Partials     2537     2530       -7     
Impacted Files Coverage Δ
modules/pipeline/services/pipelinesvc/snippet.go 54.23% <100.00%> (+12.52%) ⬆️
apistructs/pipeline_task.go 13.88% <0.00%> (-56.95%) ⬇️
...components/cmp-dashboard-pods/podsCharts/render.go 38.77% <0.00%> (-3.23%) ⬇️
modules/cmp/component-protocol/cputil/util.go 18.28% <0.00%> (-1.49%) ⬇️
modules/actionagent/callback.go 20.71% <0.00%> (-1.26%) ⬇️
...ents/cmp-dashboard-workloads-list/filter/render.go 12.76% <0.00%> (-0.43%) ⬇️
.../cmp-dashboard-workload-detail/podsTable/render.go 23.47% <0.00%> (-0.15%) ⬇️
modules/pipeline/services/pipelinesvc/detail.go 15.05% <0.00%> (-0.06%) ⬇️
cmd/actionagent/main.go 0.00% <0.00%> (ø)
modules/actionagent/exit.go 0.00% <0.00%> (ø)
... and 15 more

@littlejiancc littlejiancc force-pushed the feature/pipeline-labels branch from b9e047f to fae2836 Compare November 22, 2021 12:40
@erda-bot erda-bot requested a review from sfwn November 22, 2021 12:41
@littlejiancc littlejiancc force-pushed the feature/pipeline-labels branch from fae2836 to 6259c3b Compare November 22, 2021 12:42
@littlejiancc littlejiancc force-pushed the feature/pipeline-labels branch from 6259c3b to 79373bf Compare November 22, 2021 12:43
@sfwn sfwn added bugfix pipeline pipeline service labels Nov 23, 2021
@sfwn sfwn merged commit 2fb1148 into erda-project:master Nov 23, 2021
@littlejiancc
Copy link
Contributor Author

/cherry-pick release/1.5-alpha1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix pipeline pipeline service
Development

Successfully merging this pull request may close these issues.

2 participants