Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 💡 add log, fix some bugs #3173

Merged

Conversation

bugaolengdeyuxiaoer
Copy link
Contributor

@bugaolengdeyuxiaoer bugaolengdeyuxiaoer commented Nov 25, 2021

What type of this PR

Add one of the following kinds:
/kind bugfix

What this PR does / why we need it:

Which issue(s) this PR fixes:

  • Fixes #your-issue_number
  • [Erda Cloud Issue Link](paste your link here)

Specified Reviewers:

/assign @johnlanni

ChangeLog

Language Changelog
🇺🇸 English
🇨🇳 中文

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot requested a review from johnlanni November 25, 2021 07:42
@bugaolengdeyuxiaoer bugaolengdeyuxiaoer added cmp cloud management platform manag bugfix labels Nov 25, 2021
@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #3173 (9b6192a) into master (72403c2) will increase coverage by 0.02%.
The diff coverage is 36.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3173      +/-   ##
==========================================
+ Coverage   17.59%   17.62%   +0.02%     
==========================================
  Files        1370     1370              
  Lines      141774   141838      +64     
==========================================
+ Hits        24945    24992      +47     
+ Misses     114181   114177       -4     
- Partials     2648     2669      +21     
Impacted Files Coverage Δ
modules/cmp/metrics/metrics.go 27.02% <0.00%> (+2.14%) ⬆️
...rotocol/components/cmp-cluster-list/list/render.go 29.16% <5.55%> (+1.44%) ⬆️
...mponents/cmp-dashboard-nodes/common/table/table.go 19.95% <76.47%> (+3.49%) ⬆️
modules/dop/services/autotest_v2/testplan_v2.go 3.18% <0.00%> (-0.02%) ⬇️
modules/hepa/services/domain/impl/impl.go 1.81% <0.00%> (-0.02%) ⬇️
.../components/cmp-dashboard-pods/podsTable/render.go 18.43% <0.00%> (+0.14%) ⬆️
...ios/auto-test-plan-list/components/table/render.go 53.03% <0.00%> (+2.73%) ⬆️

@luobily
Copy link
Member

luobily commented Nov 25, 2021

/approve

@erda-bot erda-bot merged commit df9e1ab into erda-project:master Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved bugfix cmp cloud management platform manag
Development

Successfully merging this pull request may close these issues.

3 participants