Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: graph has no data in node detail from pod detail #3174

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

CraigMChen
Copy link
Contributor

What type of this PR

Add one of the following kinds:

/kind bugfix

What this PR does / why we need it:

add nodeIP query params in pod detail info

Which issue(s) this PR fixes:

  • Fixes #your-issue_number
  • [Erda Cloud Issue Link](paste your link here)

Specified Reviewers:

/assign @luobily

ChangeLog

Language Changelog
🇺🇸 English
🇨🇳 中文

@erda-bot erda-bot requested a review from luobily November 25, 2021 07:53
@CraigMChen CraigMChen added bugfix cmp cloud management platform manag labels Nov 25, 2021
@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #3174 (de75057) into master (5995494) will increase coverage by 0.00%.
The diff coverage is 38.46%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3174   +/-   ##
=======================================
  Coverage   17.60%   17.60%           
=======================================
  Files        1370     1370           
  Lines      141795   141800    +5     
=======================================
+ Hits        24958    24961    +3     
- Misses     114185   114187    +2     
  Partials     2652     2652           
Impacted Files Coverage Δ
...mponents/cmp-dashboard-podDetail/podInfo/render.go 8.42% <38.46%> (-0.25%) ⬇️
...omponents/cmp-dashboard-nodes/nodeFilter/render.go 49.33% <0.00%> (+1.33%) ⬆️

@luobily
Copy link
Member

luobily commented Nov 25, 2021

/approve

@erda-bot erda-bot merged commit 5792039 into erda-project:master Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved bugfix cmp cloud management platform manag
Development

Successfully merging this pull request may close these issues.

3 participants