Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customize alert add dingtalk_work_notice and delete vms #3177

Merged
merged 8 commits into from
Nov 26, 2021

Conversation

Counterflowwind
Copy link
Contributor

What type of this PR

Add one of the following kinds:
/kind bugfix

ChangeLog

Language Changelog
🇺🇸 English customize alert add dingtalk_work_notice and delete vms
🇨🇳 中文 自定义告警通知方式增加钉钉工作通知并删除电话

@Counterflowwind Counterflowwind added msp microsevice platform bugfix labels Nov 25, 2021
@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #3177 (157b542) into master (df9e1ab) will increase coverage by 0.01%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3177      +/-   ##
==========================================
+ Coverage   17.62%   17.63%   +0.01%     
==========================================
  Files        1370     1370              
  Lines      141843   141871      +28     
==========================================
+ Hits        24995    25023      +28     
+ Misses     114179   114152      -27     
- Partials     2669     2696      +27     
Impacted Files Coverage Δ
.../core/monitor/alert/alert-apis/adapt/expression.go 36.68% <0.00%> (+3.56%) ⬆️
...s/services/notify/channel/notify.chanel.service.go 56.69% <100.00%> (+0.08%) ⬆️
modules/cmp/metrics/metrics.go 26.69% <0.00%> (-0.34%) ⬇️
modules/dop/services/autotest_v2/testplan_v2.go 3.18% <0.00%> (-0.01%) ⬇️
modules/msp/tenant/project/project.service.go 32.22% <0.00%> (+0.27%) ⬆️
...rotocol/components/cmp-cluster-list/list/render.go 32.24% <0.00%> (+3.07%) ⬆️

@liuhaoyang
Copy link
Contributor

/approve

@erda-bot erda-bot merged commit aff1482 into erda-project:master Nov 26, 2021
@liuhaoyang
Copy link
Contributor

/cherry-pick release/1.5-alpha2

erda-bot pushed a commit to erda-bot/erda that referenced this pull request Nov 26, 2021
…#3177)

* customize alert add dingtalk_work_notice and delete vms

* Optimize logical judgment

* Optimize logical judgment

* Optimize logical judgment

* Optimize logical judgment

* Optimize logical judgment

* Optimize logical judgment
erda-bot added a commit that referenced this pull request Nov 26, 2021
* customize alert add dingtalk_work_notice and delete vms

* Optimize logical judgment

* Optimize logical judgment

* Optimize logical judgment

* Optimize logical judgment

* Optimize logical judgment

* Optimize logical judgment

Co-authored-by: panjiayao <44628544+Counterflowwind@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved bugfix msp microsevice platform
Development

Successfully merging this pull request may close these issues.

3 participants