Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimization of issue summary state #3208

Merged

Conversation

chengjoey
Copy link
Contributor

@chengjoey chengjoey commented Nov 29, 2021

What type of this PR

Add one of the following kinds:
/kind bugfix

What this PR does / why we need it:

optimization of query issue summary state
reduce the query of the sql statement

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @your-reviewer

ChangeLog

Language Changelog
🇺🇸 English Fix the bug that cost long time when query iteration
🇨🇳 中文 修复了获取迭代耗时太久

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@chengjoey chengjoey added bug dop devops plaoform labels Nov 29, 2021
@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #3208 (e5c24ac) into master (4d0444d) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3208      +/-   ##
==========================================
- Coverage   17.63%   17.62%   -0.01%     
==========================================
  Files        1371     1371              
  Lines      141944   141875      -69     
==========================================
- Hits        25037    25011      -26     
+ Misses     114280   114266      -14     
+ Partials     2627     2598      -29     
Impacted Files Coverage Δ
modules/dop/endpoints/iteration.go 12.08% <75.00%> (+12.08%) ⬆️
modules/msp/tenant/project/project.service.go 10.54% <0.00%> (-14.32%) ⬇️
...rotocol/components/cmp-cluster-list/list/render.go 30.40% <0.00%> (-1.01%) ⬇️
...mponents/cmp-dashboard-nodes/common/table/table.go 17.60% <0.00%> (+0.31%) ⬆️
modules/hepa/k8s/k8s_adapter.go 12.69% <0.00%> (+1.52%) ⬆️
.../core/monitor/alert/alert-apis/adapt/expression.go 33.76% <0.00%> (+4.54%) ⬆️

@chengjoey chengjoey force-pushed the fix/iteration-summary-optimization branch 4 times, most recently from ac74192 to 2c476de Compare November 29, 2021 08:56
apistructs/iteration.go Outdated Show resolved Hide resolved
apistructs/iteration.go Outdated Show resolved Hide resolved
@chengjoey chengjoey force-pushed the fix/iteration-summary-optimization branch from 2c476de to e5c24ac Compare November 29, 2021 11:46
@Effet Effet merged commit 0fde3bf into erda-project:master Nov 29, 2021
@Effet
Copy link
Member

Effet commented Nov 30, 2021

/cherry-pick release/1.5-alpha2

@erda-bot
Copy link
Member

Automated cherry pick failed, please resolve the confilcts and create PR manually.
Details:

[auto-cherry-pick-pr/release-1.5-alpha2-3208 2ebc85b0] optimization of issue summary state (#3208)
 Author: chengjoey <30427474+chengjoey@users.noreply.github.com>
 Date: Mon Nov 29 21:10:35 2021 +0800
 5 files changed, 181 insertions(+), 10 deletions(-)
 create mode 100644 modules/dop/endpoints/iteration_test.go

erda-bot pushed a commit to erda-bot/erda that referenced this pull request Nov 30, 2021
@erda-bot
Copy link
Member

Automated cherry pick failed, please resolve the confilcts and create PR manually.
Details:

[auto-cherry-pick-pr/release-1.5-alpha2-3208 6c5b0179] optimization of issue summary state (#3208)
 Author: chengjoey <30427474+chengjoey@users.noreply.github.com>
 Date: Mon Nov 29 21:10:35 2021 +0800
 5 files changed, 181 insertions(+), 10 deletions(-)
 create mode 100644 modules/dop/endpoints/iteration_test.go

Effet pushed a commit that referenced this pull request Nov 30, 2021
Co-authored-by: chengjoey <30427474+chengjoey@users.noreply.github.com>
@chengjoey chengjoey deleted the fix/iteration-summary-optimization branch April 18, 2022 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dop devops plaoform
Development

Successfully merging this pull request may close these issues.

3 participants