Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: sort service list about 1.error rate 2. avg duration 3. rps #3339

Merged
merged 7 commits into from
Dec 14, 2021

Conversation

innerpeacez
Copy link
Contributor

@innerpeacez innerpeacez commented Dec 10, 2021

What type of this PR

Add one of the following kinds:
/kind feature

Sorting rules:

  1. Error rate desc
  2. Time-consuming desc
  3. Throughput desc

Sorting rule priority: 1> 2> 3

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #3339 (7217a6f) into master (03f5295) will increase coverage by 0.01%.
The diff coverage is 81.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3339      +/-   ##
==========================================
+ Coverage   17.85%   17.86%   +0.01%     
==========================================
  Files        1377     1386       +9     
  Lines      142888   144372    +1484     
==========================================
+ Hits        25511    25799     +288     
- Misses     114700   115871    +1171     
- Partials     2677     2702      +25     
Impacted Files Coverage Δ
modules/monitor/apm/topology/topology.go 27.47% <0.00%> (-1.33%) ⬇️
modules/msp/apm/service/apm.service.service.go 74.03% <88.09%> (+14.03%) ⬆️
pkg/math/math.go 100.00% <100.00%> (ø)
...ashboard-workload-detail/operationButton/render.go 37.83% <0.00%> (-16.64%) ⬇️
pkg/database/sqlparser/snapshot/snapshot.go 14.81% <0.00%> (-8.89%) ⬇️
...p-dashboard-workloads-list/workloadTable/render.go 49.01% <0.00%> (-8.55%) ⬇️
...tocol/components/issue-manage/issueTable/render.go 35.81% <0.00%> (-6.16%) ⬇️
...e/monitor/metric/storage/elasticsearch/provider.go 14.42% <0.00%> (-5.58%) ⬇️
...rotocol/components/cmp-cluster-list/list/render.go 30.55% <0.00%> (-2.46%) ⬇️
... and 25 more

@innerpeacez innerpeacez added feature msp microsevice platform labels Dec 13, 2021
@liuhaoyang liuhaoyang merged commit c95c03d into erda-project:master Dec 14, 2021
@innerpeacez innerpeacez deleted the sort-service-list branch December 14, 2021 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature msp microsevice platform
Development

Successfully merging this pull request may close these issues.

2 participants