limit task retry when system error #3340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #3340 +/- ##
=========================================
Coverage 17.85% 17.85%
=========================================
Files 1377 1386 +9
Lines 142888 144326 +1438
=========================================
+ Hits 25511 25773 +262
- Misses 114700 115875 +1175
- Partials 2677 2678 +1
|
chengjoey
force-pushed
the
fix/pipeline-task-long-time-retry
branch
2 times, most recently
from
26f9358 to
4d61ffd
Compare
sfwn
requested changes
Dec 13, 2021
apistructs/pipeline_task.go
Outdated
| @@ -23,7 +23,9 @@ import ( | |||
|
|
|||
| const ( | |||
| // TerminusDefineTag add this tag env to container for collecting logs | |||
| TerminusDefineTag = "TERMINUS_DEFINE_TAG" | |||
| TerminusDefineTag = "TERMINUS_DEFINE_TAG" | |||
| PipelineTaskMaxRetryLimit = 100 | |||
There was a problem hiding this comment.
How much time will the normal result of 100 retry times cost?
Please compare to 24hours.
| @@ -96,6 +96,10 @@ func reconcileTask(tr *taskrun.TaskRun) error { | |||
| rlog.TErrorf(tr.P.ID, tr.Task.ID, "failed to handle taskOp: %s, user abnormalErr: %v, don't need retry", taskOp.Op(), abnormalErr) | |||
| return abnormalErr | |||
| } | |||
| if tr.Task.Inspect.IsErrorsExceed() { | |||
| rlog.TErrorf(tr.P.ID, tr.Task.ID, "failed to handle taskOp: %s, errors exceed limit, stop retry", taskOp.Op()) | |||
chengjoey
force-pushed
the
fix/pipeline-task-long-time-retry
branch
from
4d61ffd to
942443f
Compare
sfwn
approved these changes
Dec 16, 2021
|
/approve |
erda-bot
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Add one of the following kinds:
/kind bugfix
What this PR does / why we need it:
limit task retry when system error
Which issue(s) this PR fixes:
Specified Reviewers:
/assign @your-reviewer
ChangeLog
Need cherry-pick to release versions?
Add comment like
/cherry-pick release/1.0when this PR is merged.