Fix work bench issue data query #3354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3354 +/- ##
==========================================
+ Coverage 17.83% 17.86% +0.02%
==========================================
Files 1386 1386
Lines 144314 144384 +70
==========================================
+ Hits 25736 25789 +53
+ Misses 115902 115897 -5
- Partials 2676 2698 +22
|
sfwn
requested changes
Dec 14, 2021
modules/dop/dao/issue.go
Outdated
|
|
||
| func (client *DBClient) issueExpiryStatusQuery(req apistructs.WorkbenchRequest) *gorm.DB { | ||
| sql := client.Debug().Table("dice_issues").Joins(joinState) | ||
| sql = sql.Where("deleted = 0").Where("assignee = ? AND dice_issue_state.belong IN (?)", req.Assignees, req.StateBelongs) |
sfwn
approved these changes
Dec 15, 2021
|
/approve |
erda-bot
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
bugfix
What this PR does / why we need it:
Fix work bench issue data query
Which issue(s) this PR fixes:
Specified Reviewers:
/assign @sfwn
ChangeLog
Need cherry-pick to release versions?
Add comment like
/cherry-pick release/1.0when this PR is merged.