Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bdl requests to pass internationalized information #3362

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

kakj-go
Copy link
Contributor

@kakj-go kakj-go commented Dec 14, 2021

What type of this PR

/kind bugfix

What this PR does / why we need it:

When users call most of the apis, because the lang in the request header is not passed through the bdl call, the information returned by the subsequent apis is not internationalized, resulting in a mixture of various languages

Which issue(s) this PR fixes:

ChangeLog

Language Changelog
🇺🇸 English Internationalized delivery of bdl requests
🇨🇳 中文 bdl 请求的国际化传递

@kakj-go kakj-go force-pushed the feature/bdl-i18n branch 3 times, most recently from 2e4e1b8 to 9a5b2d5 Compare December 14, 2021 08:18
@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #3362 (7130f73) into master (cddbc81) will increase coverage by 0.03%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3362      +/-   ##
==========================================
+ Coverage   17.83%   17.86%   +0.03%     
==========================================
  Files        1386     1386              
  Lines      144314   144396      +82     
==========================================
+ Hits        25737    25800      +63     
- Misses     115901   115912      +11     
- Partials     2676     2684       +8     
Impacted Files Coverage Δ
modules/core-services/endpoints/project.go 0.00% <0.00%> (ø)
modules/core-services/services/project/project.go 15.85% <0.00%> (-0.02%) ⬇️
pkg/http/httpclient/request.go 27.55% <33.33%> (+0.07%) ⬆️
pkg/i18n/helper.go 50.00% <70.58%> (+50.00%) ⬆️
pkg/http/httpserver/server.go 42.53% <100.00%> (+0.87%) ⬆️
...odules/core/monitor/log/query/log.query.service.go 16.93% <0.00%> (-0.32%) ⬇️
modules/monitor/apm/topology/topology.go 27.54% <0.00%> (-0.05%) ⬇️
modules/core-services/endpoints/notify_group.go 0.00% <0.00%> (ø)
modules/msp/apm/service/apm.service.service.go 69.45% <0.00%> (+10.10%) ⬆️

@sfwn sfwn requested a review from Effet December 15, 2021 03:34
@Effet Effet merged commit 6d6a2a9 into erda-project:master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants